[SYCL] Align nd_range with SYCL 2020 specifications for next release - #22863
[SYCL] Align nd_range with SYCL 2020 specifications for next release#22863Robertkq wants to merge 6 commits into
Conversation
|
I believe the There are no other uses of I guess there is a very small chance for downstream users of this header to use EDIT: no longer relevant, ABI Breakage is no concern for this as classes, functions modified are templated, they don't end up in libsycl symbols |
|
@KornevNikita can you also take a look? ty |
|
Hey, just checked locally. libsycl.so doesn't contain these symbols, so it seems like we can modify this header without guards |
Hmm.. I wonder why it doesnt contain these symbols, shouldnt it contain all symbols of the exposed API / Runtime classes? Maybe I dont have enough knowledge on this.. If its convenient for you, can you check symbols for #22736 issue as well? I'll update the PR accordingly |
|
I see no symbols in https://github.com/intel/llvm/blob/sycl/sycl/test/abi/sycl_symbols_linux.dump and these functions are not marked with |
|
Can I have approval for CI & review? simple changes from this PR Thanks! |
3996911 to
01bc787
Compare
fixes #22737