Skip to content

[SYCL] Align nd_range with SYCL 2020 specifications for next release #22863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Robertkq wants to merge 6 commits into
base: sycl
Choose a base branch
from
+17 −12
Open

[SYCL] Align nd_range with SYCL 2020 specifications for next release #22863

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
90ad035
align nd_range to specs for next release
Robertkq Aug 4, 2026
046398f
small fix
Robertkq Aug 4, 2026
4edf9e6
remove guards as no ABI breakage issue
Robertkq Aug 5, 2026
94e5ed1
remove duplicate operator==
Robertkq Aug 5, 2026
01bc787
add default noexcept destructor explicitly
Robertkq Aug 6, 2026
25b72ee
address reviews
Robertkq Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions sycl/include/sycl/nd_range.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,37 +39,42 @@ template <int Dimensions = 1> class nd_range {
public:
__SYCL2020_DEPRECATED("offsets are deprecated in SYCL2020")
nd_range(range<Dimensions> globalSize, range<Dimensions> localSize,
id<Dimensions> offset)
id<Dimensions> offset) noexcept
: globalSize(globalSize), localSize(localSize), offset(offset) {}

nd_range(range<Dimensions> globalSize, range<Dimensions> localSize)
nd_range(range<Dimensions> globalSize, range<Dimensions> localSize) noexcept
: globalSize(globalSize), localSize(localSize), offset(id<Dimensions>()) {
}

range<Dimensions> get_global_range() const { return globalSize; }
range<Dimensions> get_global_range() const noexcept { return globalSize; }

range<Dimensions> get_local_range() const { return localSize; }
range<Dimensions> get_local_range() const noexcept { return localSize; }

range<Dimensions> get_group_range() const { return globalSize / localSize; }
range<Dimensions> get_group_range() const noexcept {
return globalSize / localSize;
}

__SYCL2020_DEPRECATED("offsets are deprecated in SYCL2020")
id<Dimensions> get_offset() const { return offset; }
id<Dimensions> get_offset() const noexcept { return offset; }

// Common special member functions for by-value semantics
nd_range(const nd_range<Dimensions> &rhs) = default;
nd_range(nd_range<Dimensions> &&rhs) = default;
nd_range<Dimensions> &operator=(const nd_range<Dimensions> &rhs) = default;
nd_range<Dimensions> &operator=(nd_range<Dimensions> &&rhs) = default;
nd_range() = default;
~nd_range() = default;

// Common member functions for by-value semantics
bool operator==(const nd_range<Dimensions> &rhs) const {
return (rhs.globalSize == this->globalSize) &&
(rhs.localSize == this->localSize) && (rhs.offset == this->offset);
// Common hidden friend functions for by-value semantics
friend bool operator==(const nd_range<Dimensions> &lhs,
const nd_range<Dimensions> &rhs) {
return (lhs.globalSize == rhs.globalSize) &&
(lhs.localSize == rhs.localSize) && (lhs.offset == rhs.offset);
}

bool operator!=(const nd_range<Dimensions> &rhs) const {
return !(*this == rhs);
friend bool operator!=(const nd_range<Dimensions> &lhs,
const nd_range<Dimensions> &rhs) {
return !(lhs == rhs);
}

friend class sycl::_V1::detail::nd_range_view;
Expand Down
Loading