Repository navigation
feat(e2e): add per-family end-to-end regression runner - #9894
Open
Pfannkuchensack wants to merge 12 commits into
Open
Pfannkuchensack wants to merge 12 commits into
Pfannkuchensack wants to merge 12 commits into
Conversation
Runs each installed model family through a launched scratch server and compares PSNR, time and driver-level VRAM against accepted references. Graphs come from the frontend builders via an offline graph export; the generate submission plan is shared with the workbench.
This was referenced Oct 17, 2026
Main added useNsfwChecker and useWatermark to the generation project settings; exported calibration and E2E graphs run without both, as the defaults do.
This was referenced Oct 18, 2026
Pfannkuchensack
marked this pull request as ready for review
October 21, 2026 00:45
Pfannkuchensack
requested review from
blessedcoolant,
joshistoast and
lstein
as code owners
October 21, 2026 00:45
Adds `bundle`, which packs a run's report, images, graphs and traces into a zip with local paths, credentials and PNG text metadata removed. Runs record name, base, type, format, variant and hash of every model a case uses; report and summary list them per case. AGENTS.md asks agents to offer a family run after model-related changes.
Each bundle carries bundle.json with format version, tool commit and creation time. The previous-run search filters by profile from the run id before loading, so runs of other profiles are not read.
The fake sampler now rises when the run is enqueued instead of halfway to stop, so a slow runner cannot move the peak past completion.
Cases can declare `expect: changed`; a difference from the reference then reports CHANGED, and an unchanged output fails. A run judged against its own accepted reference reports BASELINE; bundles move to format version 2. The server-tree test retries reading its pid file instead of failing on a briefly locked file.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
End-to-end checks per model family are run by hand for almost every PR today. Several recent defects would have shown up in such a run early: a tokenizer that silently loaded a one-token vocabulary, missing working-memory reservations, and samplers that ignored the img2img start point.
This adds a developer tool,
python -m scripts.family_e2e, that runs each locally installed family end to end through the real API and compares the result with an explicitly accepted reference and with the previous run:scripts/family_e2e/manifest.example.yaml.pnpm graphs:export, builds the enqueue batches with the same graph builders and component policy as the Generate and Canvas widgets. The generate submission planning (prompt templates, negative-prompt suppression, dynamic prompts, seed plan, batch data) moved into Generation and Queue and is now shared by the workbench and the export, so the two cannot drift.use_cache=falseon every node, the model cache is emptied before each family, then 1 warm-up and 3 measured runs per case and size.accept.status,stop,resume, a per-GPU lock, and a kill-on-close job object so the server never outlives its runner.Records keep per-node baseline and peak plus the raw memory trace, so several sizes per family can later feed working-memory calibration without a second run.
bundlepacks a run into a zip that opens on any machine. It holds the report and summary, rendered for the zip, with every shown image (this run, reference, previous run, difference) linked relatively, plusrun.json,records.jsonl,graphs/andtraces/. Abundle.jsonholds the zip's format version, tool commit and creation time, so readers can refuse layouts they don't know.run.jsonrecords name, base, type, format, variant, hash and a shareable source for every model a case's graph uses. The report and summary list them per case, since the local model key means nothing on another machine. Older runs without this field still load, report and bundle.AGENTS.mdasks agents to offer a family run of the affected families after changes to model loading, quantization, attention, the model cache, model-running invocations or the frontend graph builders. They should never start one unasked, and the result goes into the PR as the summary table plus the bundle zip.QA Instructions
Checks
uv run --no-sync pytest tests/family_e2e tests/app/test_database_access_guard.py: 173 passed. Theslowreal-GPU sampler test passed on an RTX 4090 (-m slow).src/hrefresolves inside it;uv tool run ruff@0.11.2 check/format --checkonscripts/family_e2e tests/family_e2e: clean.invokeai/frontend/webv2):pnpm lintpasses, includingarchitecture:check.pnpm test:fixtures: 35 passed.pnpm test:performance:buildpasses with no baseline or pin changes.pnpm test: 10,276 passed. Known failures on this machine, not caused by this change:clusterStats,indexProgress,modelCacheStore.dependencyPolicy,typographyPolicy,workbenchOwnership) intermittently hit their 30 s / 60 s timeouts. They pass alone and insidepnpm lint.Graph.model_validate+validate_self()andBatch.model_validate: txt2img for every coverage shape of all 14 generate bases, img2img for 12 bases, ControlNet for 5. ERNIE-Image and Ideogram 4 correctly report that canvas generation is not supported.Real hardware
starton the same GPU is refused by the lock.stopandresumerepeat the warm-up and add only the missing measurements.batch.dataat the expected node paths.Try it
manifest.example.yaml, fill in your model keys, and stop the dev server for the template root.python -m scripts.family_e2e start --manifest <file>, thenstatus,accept <run>,report <run>, andbundle <run>for a shareable zip.First findings from the tool
Review
Resolved
Remaining limits
image_sha256in a bundled record refers to the original PNG, before its metadata was removed.Checklist
What's Newcopy (if doing a release after this PR)