Skip to content

fix(test-specs, tests): consolidate EIP-8253 transition handling - #7

Merged
jochem-brouwer merged 3 commits into
jochem-brouwer:add-eip-8253from
spencer-tb:eip-8253-consolidated
Sep 11, 2026
Merged

jochem-brouwer merged 3 commits into
jochem-brouwer:add-eip-8253from
spencer-tb:eip-8253-consolidated

Conversation

@spencer-tb

@spencer-tb spencer-tb commented Sep 7, 2026

Copy link
Copy Markdown

Description

Follow-ups for ethereum#3535 from the local review:

  • Drop the global prestate check (verify_zero_nonce_storage_accounts) and its unit tests. The fixed list only selects the addresses bumped at the fork block; it does not say anything about other addresses in synthetic prestates, and the PR's own test_non_targeted_accounts_unaffected keeps a look-alike account through the fork.
  • Un-cap the 17 tests that were marked valid_before("EIP8253") (2 EXTCODEHASH cases, 15 ported static tests). They fill again at Amsterdam once the check is gone.
  • Parametrize test_nonce_bump_at_fork_block over an activation delay (fork block at FORK_TIMESTAMP and at FORK_TIMESTAMP + 7) and turn test_targeted_accounts_absent_from_pre_state into test_targeted_accounts_without_storage[absent, empty-storage].
  • Reword the docstrings that described the "Mainnet creator replay" as a synthetic factory at the historical creator address and nonce.

The fork_activation flag on the transition tool is left as is.

Verified locally on this head: just static clean; fill --until Amsterdam of the EIP-8253 directory (158 cases), the two EXTCODEHASH cases at Amsterdam (24) and the 15 ported files at Amsterdam (75) all pass.

Related Issues or PRs

ethereum#3535. Unblocks the Amsterdam cases of ethereum#3508, whose storage-only creation prestates the dropped check rejected.

Checklist

  • Ran fast static checks to avoid CI fails, see Code Standards & Verifying Changes: just static
  • PR title has the form <type>(<area>): <title>, where <type> and <area> come from an appropriate C-<type>, respectively A-<area>, label. The title should match the target squash commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants