fix(test-specs, tests): consolidate EIP-8253 transition handling - #7
Merged
jochem-brouwer merged 3 commits intoSep 11, 2026
Merged
jochem-brouwer merged 3 commits into
jochem-brouwer merged 3 commits into
Conversation
spencer-tb
force-pushed
the
eip-8253-consolidated
branch
from
September 10, 2026 11:34
0c5b1ff to
94d4509
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-ups for ethereum#3535 from the local review:
verify_zero_nonce_storage_accounts) and its unit tests. The fixed list only selects the addresses bumped at the fork block; it does not say anything about other addresses in synthetic prestates, and the PR's owntest_non_targeted_accounts_unaffectedkeeps a look-alike account through the fork.valid_before("EIP8253")(2 EXTCODEHASH cases, 15 ported static tests). They fill again at Amsterdam once the check is gone.test_nonce_bump_at_fork_blockover an activation delay (fork block atFORK_TIMESTAMPand atFORK_TIMESTAMP + 7) and turntest_targeted_accounts_absent_from_pre_stateintotest_targeted_accounts_without_storage[absent, empty-storage].The
fork_activationflag on the transition tool is left as is.Verified locally on this head:
just staticclean;fill --until Amsterdamof the EIP-8253 directory (158 cases), the two EXTCODEHASH cases at Amsterdam (24) and the 15 ported files at Amsterdam (75) all pass.Related Issues or PRs
ethereum#3535. Unblocks the Amsterdam cases of ethereum#3508, whose storage-only creation prestates the dropped check rejected.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.