ci: time-bound the job and the memcheck step, and retry apt fetches - #817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Twice today a main run wedged with zero output inside the memcheck step — the run for #811 sat four hours, the run for #815 twenty minutes before being cancelled. Both logs show the same signature: the step header prints, then nothing at all — not one line from
apt-get update, not the memcheck banner. The wedge is the step's apt preamble stalling on a mirror, before any of our code runs; the six-hour default job timeout is why it burns hours instead of minutes.Three bounds:
timeout-minutes: 90on the job — no run outlives an hour and a half regardless of where it wedges.timeout-minutes: 30on the memcheck step, a generous triple of its normal time (apt ~1min + the curated suite ~8min with the cases test: close the sprint's coverage gaps, and put its ownership fixes under memcheck #815 added).Acquire::Retries=3plus 30-second http/https timeouts on both apt-get invocations, so a dead mirror times out and retries instead of hanging silently.what was tested