fix: read the part view-displays query from its view, not a constant - #667
Merged
Merged
Conversation
AboutPartPanel ran QueryApiAccess.LIST_PART_VIEW_DISPLAYS (RAKHyaoB…) while the part view nanopub declared RA74rCoU… — two separate live heads, the constant having been left behind by the 2026-08-20 federation rebase. The space, user and maintained-resource panels all take the query off the view; the part panel now does the same, and the drifted constant is removed. The drift is silent and gets worse as views gain per-row actions: an action maps query result columns, so a panel running an older query version than its view declares renders no button at all. That is what would have happened to the "override..." action of issue #664, whose mapping columns only exist in the version the view points at. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqfrG3VXH5tzWXPvYJzXML
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #664.
AboutPartPanelranQueryApiAccess.LIST_PART_VIEW_DISPLAYS(RAKHyaoB…) while the part view nanopub declaredRA74rCoU…— two separate live heads, the constant having been left behind by the 2026-08-20 federation rebase. The space, user and maintained-resource panels all take the query off the view; the part panel now does the same, and the drifted constant is removed.Why it matters beyond tidiness
The drift is silent, and it gets worse as views gain per-row actions. An action maps query result columns into a pre-filled publish form, so a panel running an older query version than its view declares renders no button at all — no error, no log line. That is exactly what would have happened to the new
♻️ override...action of #664, whose mapping columns only exist in the version the view points at.Context: the nanopub side of #664
Already published live, no code change needed for them (the view constants are chain anchors,
View.getfollows supersedes):RAGnECNo…/list-view-displays-spaceRA3G86T6…/view-displays-viewRAzaL0ej…/list-view-displaysRAtVGHYy…/view-displays-viewRAKFhW1T…/list-view-displaysRAM3xp8U…/view-displays-viewRAsdgRZ1…/list-part-view-displaysRA7eYpQF…/part-view-displays-viewEach view-displays table now offers exactly one
♻️ override...per row, selected in SPARQL rather than in code: a standalone display reopens its own nanopub in override fill mode, while a preset-borne row (whose source nanopub is the preset assignment, not a display) instead opens the add-view-display form pre-filled with its view, publishing a standalone display that wins latest-wins over the preset-supplied one. The two mapping columns are exact complements, so the shared label can never double up.Presets and roles were deliberately left out of #664: a preset assignment is a
(preset, resource)pair and a role attachment is a singlegen:hasRoletriple, so deactivate/detach already covers them. (Both would also have needed more than a view change to work at all —Preset.getresolves latest only through the supersedes chain, and role IRIs arenpx:embeds-ed so they are re-minted on every new version.)Testing
🤖 Generated with Claude Code
https://claude.ai/code/session_01LqfrG3VXH5tzWXPvYJzXML