Skip to content

fix: read the part view-displays query from its view, not a constant #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tkuhn merged 1 commit into from
Aug 31, 2026
Merged

fix: read the part view-displays query from its view, not a constant #667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions src/main/java/com/knowledgepixels/nanodash/QueryApiAccess.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,18 +305,8 @@ private QueryApiAccess() {
// ref-scoped query requires root_np; the IRI-keyed variant backs the users' view. See
// docs/queries/list-view-displays{,-ref}.trig.

// Part view-displays listing (resource + partid + partclass): the owning resource's displays,
// each ?displayed_here-flagged for the specific part. RAMy6Nu supersedes RAPaHJiD (renames
// ?shown_here → ?displayed_here). RAFkUf3A (derived from RAMy6Nu) adds a ?position_label column
// (first 3 chars of the structural position) so the position cell shows e.g. "1.1" with the full
// literal on hover.
// RAs9S7c9 (supersedes RA2LG9c5) swaps the authority gate to the npa:hasGoverningSpaceRef gate
// keyed on materialized npa:hasRoleType (issue #510), preserving the ?position_label column.
// RAKHyaoB (supersedes RAs9S7c9) adds space-governed version resolution (gen:governedBy;
// docs/views-and-presets-as-maintained-resources.md): a referenced version declaring a
// governing space resolves to the newest member+-signed version of its (kind, space)
// pair via a run-once governed sub-select, falling back to the pinned version.
public static final String LIST_PART_VIEW_DISPLAYS = "RAKHyaoBCpNdbGsdPLdc8lbxLb4KuLhnmU0V2-NcxHei0/list-part-view-displays";
// The part view-displays listing is not referenced here either: AboutPartPanel takes it
// from the part view nanopub's gen:hasViewQuery and passes resource + partid + partclass.

// Ref-scoped preset-assignment listing (root_np): reads the server-materialised
// npa:PresetAssignment rows scoped by npa:forSpaceRef from the validated current space-state
Expand Down
7 changes: 5 additions & 2 deletions src/main/java/com/knowledgepixels/nanodash/component/AboutPartPanel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package com.knowledgepixels.nanodash.component;

import com.knowledgepixels.nanodash.QueryApiAccess;
import com.google.common.collect.ArrayListMultimap;
import com.google.common.collect.Multimap;
import com.knowledgepixels.nanodash.Utils;
Expand Down Expand Up @@ -100,7 +99,11 @@ public AboutPartPanel(String id, AbstractResourceWithProfile context, String par
for (IRI partClass : partClasses) {
vdParams.put("partclass", partClass.stringValue());
}
add(QueryResultTableBuilder.create("viewdisplays", new QueryRef(QueryApiAccess.LIST_PART_VIEW_DISPLAYS, vdParams), new ViewDisplay(vdView)).resourceWithProfile(context).id(context.getId()).contextId(context.getId()).build());
// Take the query from the view itself (as the space/user/maintained-resource panels do)
// rather than from a constant here: a constant silently drifts from the view's
// gen:hasViewQuery, and the view's per-row actions map columns the view's own query
// version provides.
add(QueryResultTableBuilder.create("viewdisplays", new QueryRef(vdView.getQuery().getQueryId(), vdParams), new ViewDisplay(vdView)).resourceWithProfile(context).id(context.getId()).contextId(context.getId()).build());
}

}