Repository navigation
feat(stars): show pulsating stars' light through their cycle - #1495
Merged
Merged
Conversation
…cle as dataset steps
… light-curve models
Merged
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
A Cepheid's page showed one color sphere. 125 pages now have a Pulsation dataset: ten steps, a tenth of a period apart, each the star's color at that phase's share of its brightest light. The page still opens on Color. Method note.
Sources and processing
vari_cepheid(Ripepi et al. 2023): each star's published G-band Fourier model.Also fixed: a star with a light-curve veil could not be prepared again since #1300.
No world step was run: on the map these stars stay plain dots until one runs.
Prepared assets
Evidence
Proves the change: headless Chrome on the dev site, RY CMa: each step's disc centre is its share of the star's color within one level. All 125 runtimes read back against their tables: 0 problems.
Clean: type-checks and tests of the touched packages pass; the site lane fails 6 of 1,797 locally, none naming this change.