refactor(reqresp): drop defensive finish_write lookup#740
Open
tcoratger wants to merge 1 commit into
Open
Conversation
The reqresp client opens streams via QuicConnection.open_stream(), which is typed as returning QuicStream — a class that always implements finish_write. The getattr(stream, "finish_write", None) guard at the BlocksByRoot and BlocksByRange sites was dead. The sibling status path already called stream.finish_write() directly, so this aligns the three sites. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QuicConnection.open_stream(), which is statically typed as returningQuicStream— a class that always implementsfinish_write.getattr(stream, "finish_write", None); if finish_write is not None: await finish_write()guard at the BlocksByRoot and BlocksByRange call sites was dead defensive code.stream.finish_write()directly, so this just aligns the three sites.Test plan
uv run pytest tests/lean_spec/subspecs/networking/client/— 126 tests pass.finish_write(grep acrosstests/).🤖 Generated with Claude Code