Skip to content

refactor(reqresp): drop defensive finish_write lookup #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tcoratger merged 1 commit into from
May 21, 2026
Merged

refactor(reqresp): drop defensive finish_write lookup #740

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions src/lean_spec/subspecs/networking/client/reqresp_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,7 @@ async def _do_blocks_by_root_request(
await stream.write(request_bytes)

# Half-close to signal we're done sending.
finish_write = getattr(stream, "finish_write", None)
if finish_write is not None:
await finish_write()
await stream.finish_write()

# Read response chunks.
#
Expand Down Expand Up @@ -297,9 +295,7 @@ async def _do_blocks_by_range_request(
await stream.write(request_bytes)

# Half-close to signal we're done sending.
finish_write = getattr(stream, "finish_write", None)
if finish_write is not None:
await finish_write()
await stream.finish_write()

# Read response chunks.
#
Expand Down Expand Up @@ -460,9 +456,7 @@ async def _do_status_request(
await stream.write(request_bytes)

# Half-close to signal we're done sending.
finish_write = getattr(stream, "finish_write", None)
if finish_write is not None:
await finish_write()
await stream.finish_write()

# Read peer's status response.
response_data = await stream.read()
Expand Down
Loading