Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0d1d970e1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| VERSION_VALUE=$(tr -d '\r\n' < VERSION) | ||
| if [[ "${GITHUB_REF_NAME#v}" != "$VERSION_VALUE" ]]; then | ||
| echo "Tag '$GITHUB_REF_NAME' does not match VERSION '$VERSION_VALUE'." >&2 | ||
| exit 1 |
There was a problem hiding this comment.
When any non-semver tag such as nightly is pushed, this equality check fails because the workflow subscribes to every tag, while .github/workflows/verify-release-version.yml lines 32–37 explicitly classifies such tags as non-release tags and skips validation. This makes the new PHP API CI report a failure for tag types the existing release workflow permits; either apply the same semver guard here or narrow the tag trigger to release tags.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation