-
Notifications
You must be signed in to change notification settings - Fork 0
chore(release): prepare PHP API v0.9.0 #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d2dedd9
docs(guardrails): codify remote branch policy
amasiye 616f0f7
Merge remote-tracking branch 'origin/main' into develop
amasiye 0d1d970
ci(php): validate api package on pushes and pull requests
amasiye a84f240
fix(ci): publish the PHPUnit test configuration
amasiye File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| name: PHP API CI | ||
|
|
||
| on: | ||
| pull_request: | ||
| push: | ||
| branches: | ||
| - develop | ||
| - main | ||
| tags: | ||
| - '*' | ||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Check out PHP API | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up PHP | ||
| uses: shivammathur/setup-php@v2 | ||
| with: | ||
| php-version: '8.5' | ||
| extensions: dom, json, libxml, mbstring, tokenizer, xml, xmlwriter | ||
| tools: composer:v2 | ||
| coverage: none | ||
|
|
||
| - name: Cache Composer downloads | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: ~/.cache/composer/files | ||
| key: composer-${{ runner.os }}-${{ hashFiles('composer.lock', 'composer.json') }} | ||
| restore-keys: | | ||
| composer-${{ runner.os }}- | ||
|
|
||
| - name: Install dependencies | ||
| run: composer install --no-interaction --prefer-dist --no-progress | ||
|
|
||
| - name: Validate package metadata and autoloading | ||
| run: | | ||
| composer validate --strict --no-check-publish | ||
| composer dump-autoload --optimize --strict-psr --no-interaction | ||
|
|
||
| - name: Verify release tag metadata | ||
| if: startsWith(github.ref, 'refs/tags/') | ||
| shell: bash | ||
| run: | | ||
| set -euo pipefail | ||
| VERSION_VALUE=$(tr -d '\r\n' < VERSION) | ||
| if [[ "${GITHUB_REF_NAME#v}" != "$VERSION_VALUE" ]]; then | ||
| echo "Tag '$GITHUB_REF_NAME' does not match VERSION '$VERSION_VALUE'." >&2 | ||
| exit 1 | ||
| fi | ||
|
|
||
| - name: Run PHP API tests | ||
| run: composer test -- --colors=never | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/11.0/phpunit.xsd" | ||
| bootstrap="vendor/autoload.php" | ||
| colors="true" | ||
| cacheDirectory=".phpunit.cache"> | ||
| <testsuites> | ||
| <testsuite name="Unit"> | ||
| <directory>tests</directory> | ||
| </testsuite> | ||
| </testsuites> | ||
| <source> | ||
| <include> | ||
| <directory>src</directory> | ||
| </include> | ||
| </source> | ||
| </phpunit> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When any non-semver tag such as
nightlyis pushed, this equality check fails because the workflow subscribes to every tag, while.github/workflows/verify-release-version.ymllines 32–37 explicitly classifies such tags as non-release tags and skips validation. This makes the new PHP API CI report a failure for tag types the existing release workflow permits; either apply the same semver guard here or narrow the tag trigger to release tags.Useful? React with 👍 / 👎.