Skip to content

Make atomic matrix init methods public #4465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lindsayad wants to merge 1 commit into
base: devel
Choose a base branch
from
+9 −9
Open

Make atomic matrix init methods public #4465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions include/numerics/petsc_matrix.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,6 @@ class PetscMatrix final : public PetscMatrixBase<T>

virtual void restore_original_nonzero_pattern() override;

protected:
/**
* Perform matrix initialization steps sans preallocation
* @param m The global number of rows
Expand All @@ -308,6 +307,15 @@ class PetscMatrix final : public PetscMatrixBase<T>
numeric_index_type n_l,
numeric_index_type blocksize);

/**
* Finish up the initialization process. This method does a few things which include
* - Setting the option to make new nonzeroes an error (otherwise users will just have a silent
(often huge) performance penalty
* - Marking the matrix as initialized
*/
void finish_initialization();

protected:
/*
* Performs matrix preallcation
* \param m_l The local number of rows.
Expand All @@ -319,14 +327,6 @@ class PetscMatrix final : public PetscMatrixBase<T>
const std::vector<numeric_index_type> & n_oz,
numeric_index_type blocksize);

/**
* Finish up the initialization process. This method does a few things which include
* - Setting the option to make new nonzeroes an error (otherwise users will just have a silent
(often huge) performance penalty
* - Marking the matrix as initialized
*/
void finish_initialization();

/**
* This function either creates or re-initializes a matrix called \p
* submatrix which is defined by the indices given in the \p rows
Expand Down