fix: ngrok proxy endpoint URL handling#21
Merged
Conversation
Set default port for target URL in ngrok proxy - ensure targetUrl.port falls back to 80 or 443 based on scheme so listener.forward always receives a valid host:port pair - prevents ngrok from labeling the tunnel as app://... and avoids ERR_NGROK_3004 when the user omits the port in --url
Modify URL handling to include pathname and search parameters.
|
|
odanado
reviewed
Oct 28, 2025
| return new URL(url); | ||
| const urlWithPath = new URL(url); | ||
| urlWithPath.pathname = targetUrl.pathname; | ||
| urlWithPath.search = targetUrl.search; |
Member
There was a problem hiding this comment.
It's uncommon for LIFF app endpoint URLs to include a hash, but could you also include the hash in urlWithPath, just like pathname and search, to ensure that NgrokProxy correctly forwards the entire URL?
Contributor
Author
There was a problem hiding this comment.
I added urlWithPath.hash.
Member
|
@sumihiro Could you check the CI error?
|
Contributor
Author
|
@odanado I fixed it. |
soranakahara
approved these changes
Nov 4, 2025
Member
|
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix ngrok proxy endpoint URL handling
80/443based on the incoming schemepathnameand query string when constructing the public tunnel URL so LIFF keeps non-root routesTesting
liff-cli serve --proxy-type ngrok --url http://localhost/liff/some/path