Skip to content

fix: ngrok proxy endpoint URL handling #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
odanado merged 4 commits into from
Nov 5, 2025
+7 −2
Merged

fix: ngrok proxy endpoint URL handling #21

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a3c157d
Set default port for target URL in ngrok proxy
sumihiro Oct 20, 2025
91b56d8
Enhance URL construction in ngrok-proxy
sumihiro Oct 20, 2025
10238aa
Add hash to URL in ngrok-proxy
sumihiro Nov 4, 2025
d0d4cba
fix code style issues
sumihiro Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/serve/proxy/ngrok-proxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ export class NgrokProxy implements ProxyInterface {
constructor() {}

async connect(targetUrl: URL): Promise<URL> {
const targetPort = targetUrl.port;
const targetPort =
targetUrl.port || (targetUrl.protocol === "https:" ? "443" : "80");
const targetHost = targetUrl.hostname;

if (!process.env.NGROK_AUTHTOKEN) {
Expand Down Expand Up @@ -36,7 +37,11 @@ export class NgrokProxy implements ProxyInterface {

listener.forward(`${targetHost}:${targetPort}`);

return new URL(url);
const urlWithPath = new URL(url);
urlWithPath.pathname = targetUrl.pathname;
urlWithPath.search = targetUrl.search;

@odanado odanado Oct 28, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's uncommon for LIFF app endpoint URLs to include a hash, but could you also include the hash in urlWithPath, just like pathname and search, to ensure that NgrokProxy correctly forwards the entire URL?

@sumihiro sumihiro Nov 4, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added urlWithPath.hash.

urlWithPath.hash = targetUrl.hash;
return urlWithPath;
}

async cleanup(): Promise<void> {
Expand Down