[DO NOT MERGE][ci] Run FPGA manufacturing tests on all PRs - #14
Merged
Conversation
pamaury
force-pushed
the
pr_ot_ci
branch
5 times, most recently
from
August 17, 2026 19:43
d559f86 to
fdb8251
Compare
pamaury
changed the title
AlexJones0
approved these changes
Sep 7, 2026
AlexJones0
left a comment
AlexJones0
left a comment
There was a problem hiding this comment.
Looks good - I'd appreciate if you can address/answer my one comment before merging (and this should wait for #16 to merge first anyway and be rebased on top of that).
| with: | ||
| script: | | ||
| const payload = { | ||
| sha: context.eventName === 'pull_request' ? context.payload.pull_request.head.sha : context.sha, |
There was a problem hiding this comment.
Does this not need to be:
Suggested change
| sha: context.eventName === 'pull_request' ? context.payload.pull_request.head.sha : context.sha, | |
| sha: context.eventName === 'pull_request_target' ? context.payload.pull_request.head.sha : context.sha, |
(if not, why? Repeated twice below if so.)
Collaborator
Author
There was a problem hiding this comment.
yes good catch, I changed from pull_request to pull_request_target to get a more privileged token and forgot to update this
| event_type: 'cross-repo-ci', | ||
| client_payload: { | ||
| ...payload, | ||
| target: `${context.repo.owner}/opentitan/ot-sku-ci/ot-sku-ci.yml`, |
There was a problem hiding this comment.
Seems good, just don't forget to change this to earlgrey_1.0.0 before merging :)
The mechanism used is the cross-repo ci infrastructure defined by lowRISC which enables triggering the Opentitan CI from other repositories. Signed-off-by: Amaury Pouly <amaury.pouly@opentitan.org>
AlexJones0
approved these changes
Sep 8, 2026
AlexJones0
left a comment
AlexJones0
left a comment
There was a problem hiding this comment.
LGTM if you're happy that all requisite changes have been merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mechanism used is the cross-repo ci infrastructure defined by lowRISC which enables triggering the Opentitan CI from other repositories.
Important note: in order to get a token with sufficient permissions, the FPGA CI workflow is a
pull_request_target, meaning that on a PR, it runs with the content of the workflow on themainbranch (not with the content in the PR!). For this reason, I put the FPGA workflow test in a different file.Requires lowRISC/opentitan#30802
DO NOT MERGE yet: the current branch to trigger is current a testing branch on the
opentitanrepo, the final version should useearlgrey_1.0.0when lowRISC/opentitan#30802 is merged