Skip to content

[ci] Create cross-repo ci workflow for ot-sku - #30802

Merged
pamaury merged 1 commit into
lowRISC:earlgrey_1.0.0from
pamaury:ot-sku-ci
Sep 7, 2026
Merged

[ci] Create cross-repo ci workflow for ot-sku#30802
pamaury merged 1 commit into
lowRISC:earlgrey_1.0.0from
pamaury:ot-sku-ci

Conversation

@pamaury

@pamaury pamaury commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

This workflow, which will be triggered by ot-sku, runs the provisioning tests on FPGA (CW340), using the provided ot-sku repository as the provisioning extension.

Used by lowRISC/ot-sku#14

@jwnrt

jwnrt commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

LGTM, but do you have an example run I can look at?

Comment thread .github/workflows/ot-sku-ci.yml
@pamaury

pamaury commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

LGTM, but do you have an example run I can look at?

Here is an example:
https://github.com/lowRISC/opentitan/actions/runs/32061714895/job/95484297464
There are more here:
https://github.com/lowRISC/opentitan/actions/workflows/ot-sku-ci.yml

The build currently fails because the ot-sku repository does not contain the signed files but I will fix that soon. At least it shows that the flow runs.

This workflow, which will triggered by ot-sku, runs the provisioning
tests on FPGA (CW340), using the provided ot-sku repository as the
provisioning extension.

Signed-off-by: Amaury Pouly <amaury.pouly@opentitan.org>
@rswarbrick
rswarbrick removed their request for review August 30, 2026 16:59

@AlexJones0 AlexJones0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - looks reasonable to me, with a couple of comments. Though I guess as always this kind of thing is hard to test without merging anyhow (I appreciate the examples given!)


# For CI triggered by pull requests, cancel the previous run.
concurrency:
group: ot-sku-ci-${{ inputs.pull_request || inputs.branch || inputs.merge_sha }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor nit: I guess this might cause an issue if a pull request shares a branch name? I'm not sure what the exact format of the pull_request input looks like (is it just a number?)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think pull_request is a number, so you are theoretically correct. The probability of hitting this seems very very small though. If we wanted to fix, I guess we should use a different prefix for each type?

Comment thread .github/workflows/ot-sku-ci.yml
execute_ot_sku_tests:
name: OT-SKU tests
needs: start
runs-on: [ubuntu-22.04-fpga, cw340]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to only run CW340 tests? I think there are some orchestrator tests that only support the CW310 right now (e2e_option_flags_test, e2e_ate_individ_test). Albeit perhaps these tests should instead be changed to support the CW340 😄

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's a good point. Maybe I can create a follow-up PR to add these?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

@pamaury
pamaury merged commit 615d3c7 into lowRISC:earlgrey_1.0.0 Sep 7, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants