Skip to content

feat: Apptentive V7 Support - #809

Merged
BrandonStalnaker merged 1 commit into
mainfrom
feat/Apptentive-V7
Aug 10, 2026
Merged

feat: Apptentive V7 Support#809
BrandonStalnaker merged 1 commit into
mainfrom
feat/Apptentive-V7

Conversation

@BrandonStalnaker

Copy link
Copy Markdown
Collaborator

Background

  • Apptentive released SDK 7.x (including v7.3.0), which introduces @MainActor-isolated public APIs and removes deprecated ObjC surface such as setPushProvider:deviceToken:. Apps on Apptentive 7 need a matching mParticle kit track, following the same major-version pattern used for Braze and other partner SDKs.
  • The existing apptentive-6 track remains for Apptentive 6.x; this PR adds a parallel apptentive-7 track without breaking current consumers.

What Has Changed

  • Added Kits/apptentive/apptentive-7, based on apptentive-6, targeting ApptentiveKit 7.x via SPM (from: "7.0.0") and CocoaPods (mParticle-Apptentive-7, ApptentiveKit ~> 7.0).
  • Updated kit code for Apptentive 7: use setRemoteNotificationDeviceToken:, drop no-op log-level mapping, set distribution metadata on Apptentive.shared before register, and dispatch Apptentive calls onto the main queue for MainActor isolation.
  • Prefixed kit NSLog output with mParticle -> for consistency with other kits.
  • Registered the track in Kits/matrix.json (including mirror_force_push_main: true for the initial mirror) and listed it in Kits/README.md.
  • Corrected apptentive-6 README platform support by removing tvOS (ApptentiveKit has always been iOS-only).

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Reference Issue (For employees only. Ignore if you are an outside contributor)

@BrandonStalnaker BrandonStalnaker self-assigned this Aug 10, 2026
@BrandonStalnaker
BrandonStalnaker requested a review from a team as a code owner August 10, 2026 13:57
@cursor

cursor Bot commented Aug 10, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
New integration track touches push registration, notifications, and identity/event forwarding to a third-party SDK; apptentive-6 event routing change could affect non-MPEvent base events.

Overview
Adds a new Apptentive 7 mParticle kit track (Kits/apptentive/apptentive-7) for ApptentiveKit 7.x, alongside the existing apptentive-6 track. The kit is wired for SPM/CocoaPods (mParticle-Apptentive-7), includes examples and tests, and is registered in Kits/matrix.json and Kits/README.md.

The v7 MPKitApptentive implementation adapts to Apptentive 7’s MainActor-isolated APIs by routing SDK work through a main-queue helper, registers with distribution metadata on Apptentive.shared (no mParticle log-level mapping on config), and uses setRemoteNotificationDeviceToken: instead of deprecated push APIs. Kit logs are prefixed with mParticle ->.

apptentive-6 gets a small fix: logBaseEvent: now gates on MPEvent instead of MPBaseEvent, and its README drops incorrect tvOS support.

Reviewed by Cursor Bugbot for commit f5bc08a. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown

📦 SDK Size Impact Report

Measures how much the SDK adds to an app's size (with-SDK minus without-SDK).

Metric Target Branch This PR Change
App Bundle Impact 1.79 MB 1.79 MB +N/A
Executable Impact 848 bytes 848 bytes +N/A
XCFramework Size 6.48 MB 6.48 MB +N/A

➡️ SDK size impact change is minimal.

Raw measurements

Target branch (main):

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1920,"with_sdk_executable_size_bytes":76312,"sdk_impact_kb":1836,"sdk_executable_impact_bytes":848,"xcframework_size_kb":6636}

This PR:

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1920,"with_sdk_executable_size_bytes":76312,"sdk_impact_kb":1836,"sdk_executable_impact_bytes":848,"xcframework_size_kb":6636}

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 15f2c98. Configure here.

@BrandonStalnaker
BrandonStalnaker merged commit c001419 into main Aug 10, 2026
153 of 154 checks passed
@BrandonStalnaker
BrandonStalnaker deleted the feat/Apptentive-V7 branch August 10, 2026 19:34
@cursor cursor Bot mentioned this pull request Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants