Repository navigation
P0 UI: suppress historical SV fault alarms on startup; add true-color COM board indicator - #328
Merged
Merged
Conversation
…sted SVLIFE history
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…on events, not SV faults
…cted SV stop incident
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem reproduced
At Studio launch, ESP32-P4 can be healthy, idle and verified while
SVLIFE state=STOPPED stop_cause=RUNTIME_FAULTrefers to an older hardware stop in board RAM. ExistingDeviceController::processLinepromoted this latched past cause intosvStopReason, causing a frightening red center toast and red footer even though no SV ran/stopped in the current Studio session.Fix
svLastStopCause) from active unexpected STOP observed as RUNNING → STOPPED in the present Studio connection (svUnexpectedStopObserved).SVTXFAULT, operator STOP or reconnect.BoardConnectionIndicator.qmlat the far left of the footer: discreet outlined LED + COM port + status caption. Gray DISCONNECTED, blue CONNECTING, amber PREPARING, green READY/RUNNING, red ERROR only for active stop/setup error. Drawn from current serial connection, board identity and supervisor—not stale history. Tooltip includes useful grounded next-step context.Acceptance gates
Qt QML build, deterministic session harness, Python UI source guard, Windows native preview package and lifecycle tests. Do not merge until verified green. Field acceptance remains open in issue #324.