Conversation
Contributor
Author
|
Release SDK refresh completed after Sirius #19 merged: source revision |
4 tasks
…e-cgo-bridge # Conflicts: # .claude/skills/mo-dev/references/cgo-build-test.md
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
Refs #28966. This intermediate PR does not close the migration issue.
Review notes
This PR remains draft. The CN-facing
SiriusInputcurrently exposes onlyPush, which acquires native credit after the producer has materialized vectors; design section 5 requires credit before MO allocation/copy. The pre-allocation admission API, publication failure, cancellation, and lease release ownership need design review before this PR leaves draft.Sirius #23 merged at
e2e2f08f; this PR pins that public commit atthird_party/sirius. Its tree matches the fully tested Sirius PR head. MO #29254 (Pixi GPU provider) and #29209 (MO-reader-only bindings) are merged. This branch includes authoritative MO main throughe5f70bedc4.At the earlier bridge head
3208d50034, a frozen SiriusmoPixi build produced and release-packaged the combined MO/cuVS/Sirius binary;verify-packagechecked its exact submodule SHA and runtime closure. The native bridge integration passed normal and race runs, including the two-stream cuVS → Sirius → cuVS same-process test. Focused CN/compiler Sirius tests, all 16 SDK packaging tests, and the full MO pre-push static/SCA gate passed under Pixi Go 1.26.5. The Sirius tree passed all 3,627 C++ unit cases plus native control, binding, GPU, and two-stream result suites before its content-identical merge. No Docker image or sidecar service was used.At current head
25caa13128, the MO CUDA sample Makefile and legacy Claude test entry points are byte-for-byte identical to authoritative main. A provenance audit found the optional/usr/local/cudareferences in upstream Sirius and inherited MO tooling, so this PR does not change them or its merged Sirius pin. The supported MO/Sirius embedding build still resolves CUDA through the frozen Pixi prefix; the NVIDIA driver remains host-provided. After the latest-main merge, the GPU-toolchain and runtime-image tests, wrapper-tag and native-build contract tests,make config, and the full MO pre-push SCA gate passed. The combined binary was not rebuilt after the main merge; the earlier head's runtime validation is the available evidence.The license-header scan excludes only the external Sirius submodule, which carries its own license. The bridge README documents submodule initialization, Pixi build, CN configuration, package verification, and troubleshooting.
This PR delivers the opt-in CGo/service bridge only. Embedded public SQL MO-reader/result wiring, exact-numeric parity, all-22 TPC-H validation, default cutover, and sidecar retirement remain separate milestones. Flight stays the default; direct-TAE input is deferred.
What this PR does / why we need it:
Add an opt-in CGo bridge and CN service owner for statically embedded Sirius, pinned as a MatrixOne submodule. Bound native query, input, and result ownership across cancellation and GPU work; verify the SDK against the exact submodule commit and package its runtime dependencies beside the MO binary. Keep Flight as the default backend and reject unavailable embedded execution explicitly.