Conversation
aunjgr
marked this pull request as ready for review
September 29, 2026 15:53
4 of 7 tasks
Collaborator
Author
|
Withdrawn after provenance review: the hard-coded CUDA paths in these optional scripts were introduced by upstream Sirius commits sirius-db#732 and sirius-db#1371, not by the MO embedding work. Per the integration scope, upstream tooling should remain unchanged; the MO embedding build itself resolves CUDA from Pixi. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sirius's MO embedding profile already builds CUDA from Pixi, but two auxiliary tools still searched the host's
/usr/local/cuda: the phase-22 sanitizer gate and the SF1000 patched-cuDF build helper. On hosts with only Pixi's toolkit, those tools could not run.Explicitly lock
cuda-sanitizer-apiand the CUDA 13libnvjitlink-devheader, resolve both tools from the activated Pixi prefix, and fail before clone/build if the prefix is missing or mismatched. The CUDA driver remains host-provided; no driver implementation is packaged. The benchmark README documents a dependency-only preflight.Checklist
Validation:
pixi lock --check;pixi install --frozen -e mo;P22_SELFTEST=1 P22_UNITTEST_BIN=build/mo/extension/sirius/test/cpp/sirius_unittest pixi run --frozen -e mo bash test/scripts/sanitizer_gate_22.sh;SIRIUS_CUDA_PREFLIGHT_ONLY=1 pixi run --frozen -e mo bash bench/sf1000-repro/build-libcudf.sh;pixi run --frozen -e mo pre-commit run -a. Full SF1000 patched-cuDF compilation and GPU sanitizer workload were not run.References
Refs matrixorigin/matrixone#29203.