Skip to content

chore(golang): remove unconsumed dependencies - #18506

Open
Mitch Zhu (miz060) wants to merge 1 commit into
mitchzhu/golang-dependency-cycle-pruningfrom
mitchzhu/remove-abandoned-go-cycle-leaves
Open

chore(golang): remove unconsumed dependencies#18506
Mitch Zhu (miz060) wants to merge 1 commit into
mitchzhu/golang-dependency-cycle-pruningfrom
mitchzhu/remove-abandoned-go-cycle-leaves

Conversation

@miz060

@miz060 Mitch Zhu (miz060) commented Aug 19, 2026

Copy link
Copy Markdown
Member

Remove six Fedora-retired Go components that Azure Linux no longer needs.

Isolated Prometheus dependency cycle: no Azure package outside this group consumes these RPMs, and larger applications bundle the Prometheus modules.

  • golang-github-prometheus-common
  • golang-github-prometheus-client
  • golang-github-mwitkow-conntrack
  • golang-github-grpc-ecosystem-prometheus

Unused leaves:

  • golang-github-census-instrumentation-opencensus-proto: no consumers remain after go-control-plane 0.13.4 removes the deprecated OpenCensus APIs.
  • golang-github-tmc-grpc-websocket-proxy: no Azure Linux reverse dependencies.

Validation:

  • The full azldev configuration loads, all six removed components report not found, and no tracked package or image references remain.

@miz060
Mitch Zhu (miz060) marked this pull request as ready for review August 19, 2026 01:37
@miz060
Mitch Zhu (miz060) requested a review from a team as a code owner August 19, 2026 01:37
@miz060
Mitch Zhu (miz060) force-pushed the mitchzhu/remove-abandoned-go-cycle-leaves branch from cb34767 to 5a97a83 Compare August 19, 2026 02:29
@miz060
Mitch Zhu (miz060) force-pushed the mitchzhu/remove-abandoned-go-cycle-leaves branch from 5a97a83 to e8026e5 Compare August 19, 2026 17:50
Copilot AI balanced review requested due to automatic review settings August 19, 2026 17:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes four abandoned, unconsumed Go components and their generated packaging state.

Changes:

  • Removes component registrations and obsolete check-disablement entries.
  • Deletes corresponding locks, rendered specs, and source manifests.
  • Retains the separately namespaced OpenCensus 0.2 dependency.

Reviewed changes

Copilot reviewed 10 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
base/comps/components.toml Removes four component registrations.
base/comps/component-check-disablement.toml Removes obsolete test-disablement entries.
locks/golang-github-census-instrumentation-opencensus-proto.lock Deletes the component lock.
locks/golang-github-grpc-ecosystem-prometheus.lock Deletes the component lock.
locks/golang-github-mwitkow-conntrack.lock Deletes the component lock.
locks/golang-github-tmc-grpc-websocket-proxy.lock Deletes the component lock.
specs/g/golang-github-census-instrumentation-opencensus-proto/golang-github-census-instrumentation-opencensus-proto.spec Deletes the rendered RPM spec.
specs/g/golang-github-census-instrumentation-opencensus-proto/sources Deletes its source manifest.
specs/g/golang-github-grpc-ecosystem-prometheus/golang-github-grpc-ecosystem-prometheus.spec Deletes the rendered RPM spec.
specs/g/golang-github-grpc-ecosystem-prometheus/sources Deletes its source manifest.
specs/g/golang-github-mwitkow-conntrack/golang-github-mwitkow-conntrack.spec Deletes the rendered RPM spec.
specs/g/golang-github-mwitkow-conntrack/sources Deletes its source manifest.
specs/g/golang-github-tmc-grpc-websocket-proxy/golang-github-tmc-grpc-websocket-proxy.spec Deletes the rendered RPM spec.
specs/g/golang-github-tmc-grpc-websocket-proxy/sources Deletes its source manifest.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@miz060
Mitch Zhu (miz060) force-pushed the mitchzhu/remove-abandoned-go-cycle-leaves branch from e8026e5 to 66ee2e7 Compare August 20, 2026 02:24
Copilot AI review requested due to automatic review settings August 20, 2026 02:24
@miz060 Mitch Zhu (miz060) changed the title chore(golang-github-mwitkow-conntrack,golang-github-census-instrumentation-opencensus-proto,golang-github-grpc-ecosystem-prometheus,golang-github-tmc-grpc-websocket-proxy): remove abandoned leaves chore(golang): remove abandoned dependency leaves Aug 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 25 changed files in this pull request and generated no new comments.

Remove an isolated four-package Prometheus dependency cycle and two additional Fedora-retired Go packages with no remaining Azure Linux consumers. Larger applications already bundle the Prometheus modules.

Keep grpc-gateway v1 and OpenCensus proto 0.2 because Azure autorest still reaches that chain through the OpenCensus ocagent exporter. Keep go-control-plane because grpc-go still imports its xDS APIs.

Signed-off-by: Mitch Zhu <mitchzhu@microsoft.com>
Copilot AI review requested due to automatic review settings August 20, 2026 02:49
@miz060
Mitch Zhu (miz060) force-pushed the mitchzhu/remove-abandoned-go-cycle-leaves branch from 66ee2e7 to e458f1a Compare August 20, 2026 02:49
@miz060 Mitch Zhu (miz060) changed the title chore(golang): remove abandoned dependency leaves chore(golang): remove unconsumed dependencies Aug 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 17 out of 23 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants