Skip to content

chore(cloud): resolve AzureRM provider deprecation warnings and Grafana version error#591

Merged
katriendg merged 5 commits into
mainfrom
chore/tf-deprec-notices
Jun 10, 2026
Merged

chore(cloud): resolve AzureRM provider deprecation warnings and Grafana version error#591
katriendg merged 5 commits into
mainfrom
chore/tf-deprec-notices

Conversation

@katriendg

Copy link
Copy Markdown
Collaborator

Description

Resolved AzureRM provider deprecation warnings and a Grafana Standard SKU version error across cloud and edge Terraform components. The changes fall into three categories: renaming deprecated parent_id arguments, narrowing a resource output to explicit fields, and bumping the default Grafana version.

Provider Deprecation Fixes

Renamed the deprecated parent_id argument to user_assigned_identity_id in all azurerm_federated_identity_credential resources. This is a mechanical rename — values and behavior are identical.

  • src/000-cloud/080-azureml/terraform/modules/inference-cluster-integration/main.tf
  • src/100-edge/110-iot-ops/terraform/modules/customer-managed-trust-issuer/main.tf
  • src/100-edge/110-iot-ops/terraform/modules/iot-ops-init/main.tf (two resources)
  • src/100-edge/140-azureml/terraform/modules/inference-cluster-integration/main.tf

Output Narrowing

Narrowed the log_analytics_workspace output in src/000-cloud/020-observability/terraform/outputs.tf from a full resource object to an explicit map of five fields: id, name, location, workspace_id, and primary_shared_key.

This resolves a deprecation warning about sensitive attributes leaking through full-object outputs. All downstream consumers were verified to access only the retained fields.

Grafana Version

Updated the default Grafana major version from "11" to "12" in both Terraform and Bicep:

  • src/000-cloud/020-observability/terraform/variables.tfgrafana_major_version default
  • src/000-cloud/020-observability/bicep/main.bicepgrafanaMajorVersion param default

The AzureRM provider and Azure resource API require version 12 for Standard SKU Grafana resources.

Related Issue

Fixes #590

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Blueprint modification or addition
  • Component modification or addition
  • Documentation update
  • CI/CD pipeline change
  • Other (please describe):

Implementation Details

  1. Replaced all parent_id arguments with user_assigned_identity_id in azurerm_federated_identity_credential resources across cloud AzureML, IoT Operations init, and edge AzureML modules.
  2. Converted the log_analytics_workspace output from passing the entire azurerm_log_analytics_workspace resource to a map of explicitly selected fields, preserving all fields consumed by downstream blueprints and components.
  3. Bumped the Grafana default version to 12 in both Terraform (variables.tf) and Bicep (main.bicep) to resolve a provider/API validation error with Standard SKU.

Testing Performed

  • Terraform plan/apply
  • Blueprint deployment test
  • Unit tests
  • Integration tests
  • Bug fix includes regression test (see Test Policy)
  • Manual validation
  • Other:

Validation Steps

  1. Run terraform plan in any blueprint referencing the modified components (e.g., blueprints/full-single-node-cluster/terraform).
  2. Verify no deprecation warnings appear for parent_id or full-object output references.
  3. Confirm Grafana resource plans successfully with version 12.

Checklist

  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have run terraform fmt on all Terraform code
  • I have run terraform validate on all Terraform code
  • I have run az bicep format on all Bicep code
  • I have run az bicep build to validate all Bicep code
  • I have checked for any sensitive data/tokens that should not be committed
  • Lint checks pass (run applicable linters for changed file types)

Security Review

  • No credentials, secrets, or tokens are hardcoded or logged
  • RBAC and identity changes follow least-privilege principles
  • No new network exposure or public endpoints introduced without justification
  • Dependency additions or updates have been reviewed for known vulnerabilities
  • Container image changes use pinned digests or SHA references

Additional Notes

  • The output narrowing is technically a breaking change for any hypothetical consumer accessing fields beyond the five exported ones (e.g., .resource_group_name). All current consumers were verified — none access excluded fields.
  • The Bicep grafanaMajorVersion param default was also updated from '11' to '12' to match the Terraform change.

katriendg added 2 commits June 9, 2026 10:52
…na version error

- update Grafana default version from 11 to 12 for Standard SKU support
- rename parent_id to user_assigned_identity_id in federated identity credentials
- narrow log_analytics_workspace output to explicit fields

🔧 - Generated by Copilot
…on and parameters

🔧 - Generated by Copilot
@katriendg katriendg requested a review from a team as a code owner June 9, 2026 09:08
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

📚 Documentation Health Report

Generated on: 2026-06-09 09:13:29 UTC

📈 Documentation Statistics

Category File Count
Main Documentation 222
Infrastructure Components 197
Blueprints 39
GitHub Resources 26
AI Assistant Guides (Copilot) 17
Total 501

🏗️ Three-Tree Architecture Status

  • ✅ Bicep Documentation Tree: Auto-generated navigation
  • ✅ Terraform Documentation Tree: Auto-generated navigation
  • ✅ README Documentation Tree: Manual README organization

🔍 Quality Metrics

  • Frontmatter Validation:
    success
  • Link Validation: success

This report is automatically generated by the Documentation Automation workflow.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

📚 Documentation Health Report

Generated on: 2026-06-09 10:21:07 UTC

📈 Documentation Statistics

Category File Count
Main Documentation 222
Infrastructure Components 197
Blueprints 39
GitHub Resources 26
AI Assistant Guides (Copilot) 17
Total 501

🏗️ Three-Tree Architecture Status

  • ✅ Bicep Documentation Tree: Auto-generated navigation
  • ✅ Terraform Documentation Tree: Auto-generated navigation
  • ✅ README Documentation Tree: Manual README organization

🔍 Quality Metrics

  • Frontmatter Validation:
    success
  • Link Validation: success

This report is automatically generated by the Documentation Automation workflow.

@github-actions

Copy link
Copy Markdown

📚 Documentation Health Report

Generated on: 2026-06-10 08:38:49 UTC

📈 Documentation Statistics

Category File Count
Main Documentation 222
Infrastructure Components 197
Blueprints 39
GitHub Resources 26
AI Assistant Guides (Copilot) 17
Total 501

🏗️ Three-Tree Architecture Status

  • ✅ Bicep Documentation Tree: Auto-generated navigation
  • ✅ Terraform Documentation Tree: Auto-generated navigation
  • ✅ README Documentation Tree: Manual README organization

🔍 Quality Metrics

  • Frontmatter Validation:
    success
  • Link Validation: success

This report is automatically generated by the Documentation Automation workflow.

@github-actions

Copy link
Copy Markdown

📚 Documentation Health Report

Generated on: 2026-06-10 12:13:22 UTC

📈 Documentation Statistics

Category File Count
Main Documentation 222
Infrastructure Components 197
Blueprints 39
GitHub Resources 26
AI Assistant Guides (Copilot) 17
Total 501

🏗️ Three-Tree Architecture Status

  • ✅ Bicep Documentation Tree: Auto-generated navigation
  • ✅ Terraform Documentation Tree: Auto-generated navigation
  • ✅ README Documentation Tree: Manual README organization

🔍 Quality Metrics

  • Frontmatter Validation:
    success
  • Link Validation: success

This report is automatically generated by the Documentation Automation workflow.

@katriendg katriendg merged commit 2f36dbc into main Jun 10, 2026
46 checks passed
@katriendg katriendg deleted the chore/tf-deprec-notices branch June 10, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: resolve Terraform AzureRM provider deprecation warnings and Grafana version error

2 participants