chat: show native MCP configuration sources - #333936
Merged
Merged
Conversation
Use the MCP collection origin when an installed server definition does not carry its own origin, while preserving definition-level precedence. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Vritant Bhardwaj (vritant24)
September 2, 2026 04:59
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused implementation matches the stated behavior and includes appropriate regression coverage.
Review tier: Balanced
Findings: None
What changed in this PR
Adds collection-level URI fallback so MCP details show native configuration filenames while preserving source precedence.
Changes:
- Uses collection origin when definition origin is unavailable.
- Adds coverage for fallback and precedence behavior.
| File | Description |
|---|---|
mcpListWidget.ts |
Adds collection-origin fallback for MCP details. |
mcpListWidget.test.ts |
Tests fallback and definition precedence. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Vritant Bhardwaj (vritant24)
marked this pull request as ready for review
September 2, 2026 05:27
Anthony Kim (anthonykim1)
approved these changes
Sep 2, 2026
Vritant Bhardwaj (vritant24)
deleted the
fix/mcp-detail-native-source
branch
September 2, 2026 14:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcp.jsonfallback while preserving definition-level precedence.Technical context for AI-assisted review
Intent and previous behavior
The AI Customizations MCP detail input only read
server.presentation.origin. Native discovery records configuration files such as Copilot, Claude Desktop, Cursor, and Windsurf configs oncollection.presentation.origin, so the embedded detail rendered its source-absentmcp.jsonfallback.Implementation
The installed-detail adapter now reads the server and collection definitions together. It uses the definition origin first, falls back to the collection origin wrapped in the detail input's source shape, and retains the active-session source as the final fallback.
Behavior and constraints