Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -987,15 +987,17 @@ function createBuiltinEntry(server: IMcpServer, activeSessionServer?: AgentHostM
};
}

function createInstalledMcpServerDetailInput(entry: IMcpInstalledEntry): IMcpServerDetailInput {
export function createInstalledMcpServerDetailInput(entry: IMcpInstalledEntry): IMcpServerDetailInput {
if (entry.type === 'server-item') {
return createWorkbenchMcpServerDetailInput(entry.server);
}

const activeSessionServer = getActiveSessionServer(entry);
const localServer = entry.type === 'session-server-item' ? undefined : entry.localServer;
const localDefinition = localServer?.readDefinitions().get().server;
const localSource = localDefinition?.presentation?.origin;
const localDefinitions = localServer?.readDefinitions().get();
const localDefinition = localDefinitions?.server;
const collectionOrigin = localDefinitions?.collection?.presentation?.origin;
const localSource = localDefinition?.presentation?.origin ?? (collectionOrigin ? { uri: collectionOrigin } : undefined);
const activeSessionSource = activeSessionServer?.sourceUri
? {
uri: activeSessionServer.sourceUri,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,13 @@ import { IAICustomizationWorkspaceService } from '../../../common/aiCustomizatio
import { ICustomizationHarnessService } from '../../../common/customizationHarnessService.js';
import { IAgentHostCustomizationService } from '../../../browser/agentSessions/agentHost/agentHostCustomizationService.js';
import { IAgentPluginService } from '../../../common/plugins/agentPluginService.js';
import { IMcpService, McpConnectionState } from '../../../../mcp/common/mcpTypes.js';
import { IMcpServer, IMcpService, McpConnectionState, McpServerTransportType } from '../../../../mcp/common/mcpTypes.js';
import { DisableMcpServerForWorkspaceAction, DisableMcpServerGloballyAction, EnableMcpServerForWorkspaceAction, EnableMcpServerGloballyAction } from '../../../../mcp/browser/mcpServerActions.js';
import {
AgentHostMcpServer,
authenticateMcpServer,
createBuiltinActiveSessionMcpEntries,
createInstalledMcpServerDetailInput,
getActiveSessionServerLifecycleAction,
getActiveSessionServerPresentation,
getBuiltinMcpServerEnablementActions,
Expand Down Expand Up @@ -96,6 +97,29 @@ function createMcpService(enablement: ContributionEnablementState): { service: I
return { service, calls };
}

function createMcpDetailTestServer(definitionOrigin?: URI, collectionOrigin?: URI): IMcpServer {
const definitions = observableValue('definitions', {
server: {
id: 'server-1',
label: 'Server One',
launch: {
type: McpServerTransportType.Stdio,
command: 'server',
args: [],
env: {},
},
cacheNonce: 'server-1',
presentation: definitionOrigin ? { origin: { uri: definitionOrigin } } : undefined,
},
collection: {
presentation: collectionOrigin ? { origin: collectionOrigin } : undefined,
},
});
return {
readDefinitions: () => definitions,
} as unknown as IMcpServer;
}

function runAction(action: IAction | undefined): void {
assert.ok(action, 'expected an action to be defined');
void action.run();
Expand Down Expand Up @@ -193,6 +217,33 @@ suite('mcpListWidget', () => {
});
});

test('uses collection origin as the installed MCP detail fallback', () => {
const definitionOrigin = URI.file('/definition/mcp.json');
const collectionOrigin = URI.file('/collection/mcp-config.json');
const collectionFallback = createInstalledMcpServerDetailInput({
type: 'builtin-item',
id: 'collection-origin',
label: 'Collection Origin',
description: '',
localServer: createMcpDetailTestServer(undefined, collectionOrigin),
});
const definitionPrecedence = createInstalledMcpServerDetailInput({
type: 'builtin-item',
id: 'definition-origin',
label: 'Definition Origin',
description: '',
localServer: createMcpDetailTestServer(definitionOrigin, collectionOrigin),
});

assert.deepStrictEqual({
collectionFallback: collectionFallback.source,
definitionPrecedence: definitionPrecedence.source,
}, {
collectionFallback: { uri: collectionOrigin },
definitionPrecedence: { uri: definitionOrigin },
});
});

test('toggles MCP enablement without changing its scope', () => {
assert.deepStrictEqual([
getToggledMcpEnablementState(ContributionEnablementState.EnabledProfile),
Expand Down
Loading