Boxrunner - #62
Merged
Merged
Conversation
gkostin1966
force-pushed
the
boxrunner
branch
7 times, most recently
from
August 5, 2026 11:53
756e290 to
7c3cabe
Compare
rshiggin
reviewed
Aug 5, 2026
rshiggin
reviewed
Aug 5, 2026
rshiggin
previously requested changes
Aug 5, 2026
Member
|
Forgot to say: with the two minor commits I added this branch is running as designed in my local dev. |
gkostin1966
force-pushed
the
boxrunner
branch
3 times, most recently
from
August 19, 2026 13:12
5034782 to
8b4041f
Compare
ssciolla
approved these changes
Aug 19, 2026
ssciolla
left a comment
ssciolla
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. I'm giving an approval without super careful study, since this is mostly a migration of the current code. I'll keep looking at it and we can iterate on anything that needs to be addressed. We discussed in our meeting a couple things to do before merging, some of which I highlighted again in comments as reminders.
Collaborator
There was a problem hiding this comment.
I'd like this to be removed from the repo, and the info stashed somewhere.
| context: . | ||
| ports: | ||
| - '3000:3000' | ||
| - '3000:80' |
Collaborator
There was a problem hiding this comment.
Can we keep this the same?
Make the Resque-backed EAD ingest/packaging pipeline work end-to-end against real Solr data, fixing a chain of previously-untested bugs found during a full real-data run. - Package::Generator#fetch_components: query Solr block-join children via _root_:<collection.id> (components carry no ead_ssi), skip the level-0 collection doc, key tmp_map by document id so parent_ids lookups resolve, and fall back gracefully for orphaned components. - Null-safe optional DOM mutations in update_package_html/_pdf and TOC. - Relocate the PDF fallback font from data/fonts (ephemeral volume mount) to public/fonts (baked into the image) and reference it by absolute Rails.root path so PDF generation no longer breaks on a volume recreate. - FindingAid::IndexFromEad: load the Arclight EAD2 traject config so indexed docs get an id (fixes missing uniqueKey rejections). - Enable ingest automation + Resque ActiveJob adapter + allowed host in development.rb (containers run RAILS_ENV=development); keep automation flag in production.rb too. - bin/docker-entrypoint: also run db:prepare for the resque worker so the packager's in-process render doesn't 500 on pending migrations. - Dockerfile/compose: shared finding-aid-data volume + supporting config. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additions Only!