Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
d0479b6
RSpec folder
gkostin1966 Aug 4, 2026
92fe439
lib/box folder and lib/ingest.rake file
gkostin1966 Aug 4, 2026
70dcd74
RSpec and Rubocop config files
gkostin1966 Aug 4, 2026
e4924a2
Comment out Style/FrozenStringLiteralComment for now
gkostin1966 Aug 4, 2026
bab9810
services folder
gkostin1966 Aug 4, 2026
8976b52
sample-ead folder
gkostin1966 Aug 4, 2026
7b1a402
app/errors and app/jobs and bin/spec
gkostin1966 Aug 4, 2026
16938e9
data folder
gkostin1966 Aug 4, 2026
8e878b8
resque and rspec
gkostin1966 Aug 4, 2026
b5e5a52
Gemfile.lock
gkostin1966 Aug 4, 2026
eab3250
Changes to assest need to support upgrade of Sprockets
gkostin1966 Aug 4, 2026
4e17d77
ignore data subfolders ead, xml, and pdf
gkostin1966 Aug 4, 2026
7464aea
rename boxrunner to boxwalker
gkostin1966 Aug 4, 2026
2983124
bin/rspec 5 failures
gkostin1966 Aug 4, 2026
e50d189
views arclight fragments overrides
gkostin1966 Aug 4, 2026
f8cfade
update specs
gkostin1966 Aug 4, 2026
50ad5ed
refactor generator
gkostin1966 Aug 5, 2026
a410163
refactor to use FINDING_AID_DATA environment variable
gkostin1966 Aug 5, 2026
f7c7648
add rspec to ci
gkostin1966 Aug 5, 2026
906ba1c
rubocop and generate error fixes
gkostin1966 Aug 5, 2026
bb6dbd0
Replace puts with Rails.logger in generator.
gkostin1966 Aug 5, 2026
28593c9
improve the performance of specs
gkostin1966 Aug 5, 2026
68df65d
Restore 'lib/' to the file path to ead2_config.rb
rshiggin Aug 5, 2026
0427ebf
changes that needed to run on Jie's computer, and all specs are passed
smiskiway Aug 14, 2026
350430b
bump brakeman to 8.0.6
gkostin1966 Aug 19, 2026
606ed16
get specs to pass
gkostin1966 Aug 19, 2026
102bd67
Fix and harden the finding-aid ingest & packaging pipeline
smiskiway Aug 19, 2026
274f290
Delete two redundant SASS files
rshiggin Aug 19, 2026
6d56590
final before merge
gkostin1966 Aug 19, 2026
f9d1fa2
ead2 component config from main branch
gkostin1966 Aug 20, 2026
86aa856
bin/rubocop --autocorrect
gkostin1966 Aug 20, 2026
a33b0e6
add to_field parent_ssi
gkostin1966 Aug 20, 2026
2838341
Update to README.md
gkostin1966 Aug 20, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,34 @@ jobs:
- name: Lint code for consistent style
run: bin/rubocop -f github

spec:
runs-on: ubuntu-latest

# services:
# redis:
# image: valkey/valkey:8
# ports:
# - 6379:6379
# options: --health-cmd "redis-cli ping" --health-interval 10s --health-timeout 5s --health-retries 5
Comment thread
gkostin1966 marked this conversation as resolved.
steps:
- name: Install packages
run: sudo apt-get update && sudo apt-get install --no-install-recommends -y libvips node-gyp

- name: Checkout code
uses: actions/checkout@v7

- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
bundler-cache: true

- name: Run specs
env:
RAILS_ENV: test
# RAILS_MASTER_KEY: ${{ secrets.RAILS_MASTER_KEY }}
# REDIS_URL: redis://localhost:6379/0
run: bin/rspec

test:
runs-on: ubuntu-latest

Expand Down
5 changes: 5 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,8 @@

# Ignore key files for decrypting credentials and more.
/config/*.key

# Ignore data files that are generated by the application and should not be committed to the repository.
/data/ead
/data/xml
/data/pdf
1 change: 1 addition & 0 deletions .rspec
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
--require spec_helper
7 changes: 7 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,15 @@
inherit_from: .rubocop_todo.yml

# Omakase Ruby styling for Rails
inherit_gem: { rubocop-rails-omakase: rubocop.yml }

# Overwrite or add rules to create your own house style
#
# Enforce explicit frozen string literal magic comments.
#Style/FrozenStringLiteralComment:
# Enabled: true
# EnforcedStyle: always_true

# # Use `[a, [b, c]]` not `[ a, [ b, c ] ]`
# Layout/SpaceInsideArrayLiteralBrackets:
# Enabled: false
21 changes: 21 additions & 0 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# This configuration was generated by
# `rubocop --auto-gen-config --auto-gen-only-exclude --no-exclude-limit`
# on 2026-06-25 15:59:23 UTC using RuboCop version 1.87.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 2
# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes, Max.
Metrics/AbcSize:
Exclude:
- 'app/services/package/generator.rb'
- 'lib/box/package/generator.rb'

# Offense count: 4
# Configuration parameters: CountComments, Max, CountAsOne, AllowedMethods, AllowedPatterns.
Metrics/MethodLength:
Exclude:
- 'app/services/package/generator.rb'
- 'lib/box/package/generator.rb'
8 changes: 8 additions & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,14 @@ WORKDIR /rails
# Install base packages
RUN apt-get update -qq && \
apt-get install --no-install-recommends -y curl libjemalloc2 libvips sqlite3 && \
# wkhtmltopdf is no longer packaged in Debian bookworm; install the official
# static build (.deb) so the PDF packager can shell out to it. Installing a
# local .deb via apt lets it resolve the font/X11 dependencies automatically.
arch="$(dpkg --print-architecture)" && \
curl -fsSL -o /tmp/wkhtmltox.deb \
"https://github.com/wkhtmltopdf/packaging/releases/download/0.12.6.1-3/wkhtmltox_0.12.6.1-3.bookworm_${arch}.deb" && \
apt-get install --no-install-recommends -y /tmp/wkhtmltox.deb && \
rm -f /tmp/wkhtmltox.deb && \
ln -s /usr/lib/$(uname -m)-linux-gnu/libjemalloc.so.2 /usr/local/lib/libjemalloc.so && \
rm -rf /var/lib/apt/lists /var/cache/apt/archives

Expand Down
12 changes: 11 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,14 @@ gem "image_processing", "~> 1.2"

# date range chart
gem "blacklight_range_limit", ">= 9.2"
# job worker queue
gem "resque", "~> 3.0"
gem "redis"
gem "resque-scheduler"
# NOTE: The Resque dashboard is served by Resque::Server (bundled with the
# `resque` gem) via config/resque_web.ru. The separate `resque-web` gem is
# intentionally NOT used: it depends on sass-rails/sprockets, which conflicts
# with this app's Propshaft asset pipeline and breaks `assets:precompile`.

group :development, :test do
# See https://guides.rubyonrails.org/debugging_rails_applications.html#debugging-with-the-debug-gem
Expand All @@ -53,7 +61,7 @@ group :development, :test do
gem "bundler-audit", require: false

# Static analysis for security vulnerabilities [https://brakemanscanner.org/]
gem "brakeman", "~> 8.0.5", require: false
gem "brakeman", "~> 8.0.6", require: false

# Omakase Ruby styling [https://github.com/rails/rubocop-rails-omakase/]
gem "rubocop-rails-omakase", require: false
Expand All @@ -73,9 +81,11 @@ gem "arclight"

group :development, :test do
gem "solr_wrapper", ">= 0.3"
gem "rspec-rails", "~> 8.0"
end
gem "rsolr", ">= 1.0", "< 3"
gem "bootstrap", "~> 5.3"
gem "devise"
gem "devise-guests", "~> 0.8"
gem "blacklight-locale_picker"
gem "benchmark"
Loading