Skip to content

Pre-release clean-up#25

Open
jnnr wants to merge 12 commits into
mainfrom
fix-clean-up
Open

Pre-release clean-up#25
jnnr wants to merge 12 commits into
mainfrom
fix-clean-up

Conversation

@jnnr

@jnnr jnnr commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator
  • Properly use warnings.warn
  • Use logger.info instead of print
  • Delete unused and unfinished function get_uniform_proxy
  • Skip performance test on CI.

@irm-codebase irm-codebase left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Comment thread .pre-commit-config.yaml

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice-to-have:

Consider an end-of-file fixer too.

repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
  rev: v4.5.0
  hooks:
    - id: trailing-whitespace
      files: (^|/)a/.+\.(py|html|sh|css|js)$
    - id: end-of-file-fixer
      files: (^|/)a/.+\.(py|html|sh|css|js)$
    - id: check-added-large-files
      args: ["--maxkb=2000"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants