Skip to content

Define the visible-page sort function, used in getVisibleElements, once - #21787

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:visibleSort
Aug 16, 2026
Merged

Define the visible-page sort function, used in getVisibleElements, once#21787
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:visibleSort

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

When scrolling through long documents, especially when using spread modes and/or wrapped scrolling, the visible-page sorting can be invoked a lot.
Hence it seems like a good idea to define the sort function just once, rather than re-creating it for every invocation.

…once

When scrolling through long documents, especially when using spread modes and/or wrapped scrolling, the visible-page sorting can be invoked *a lot*.
Hence it seems like a good idea to define the sort function just once, rather than re-creating it for every invocation.
@codecov-commenter

codecov-commenter commented Aug 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.16%. Comparing base (6694c0e) to head (d8e5a04).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21787      +/-   ##
==========================================
- Coverage   90.16%   90.16%   -0.01%     
==========================================
  Files         264      264              
  Lines       67268    67266       -2     
==========================================
- Hits        60652    60649       -3     
- Misses       6616     6617       +1     
Flag Coverage Δ
browsertest 66.29% <0.00%> (-0.03%) ⬇️
integrationtest 69.37% <100.00%> (+<0.01%) ⬆️
unittest 58.28% <100.00%> (+0.01%) ⬆️
unittestcli 56.81% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij
timvandermeij merged commit fc88061 into mozilla:master Aug 16, 2026
17 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

Good idea; thanks!

@Snuffleupagus
Snuffleupagus deleted the visibleSort branch August 16, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants