Skip to content

Define the visible-page sort function, used in getVisibleElements, once #21787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timvandermeij merged 1 commit into from
Aug 16, 2026
+6 −7
Merged

Define the visible-page sort function, used in getVisibleElements, once #21787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions web/ui_utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,11 @@ function backtrackBeforeAllVisibleElements(index, views, top) {
return index;
}

function visibleSort(a, b) {
const pc = a.percent - b.percent;
return Math.abs(pc) > 0.001 ? -pc : a.id - b.id; // ensure stability
}

/**
* @typedef {Object} GetVisibleElementsParameters
* @property {HTMLElement} scrollEl - A container that can possibly scroll.
Expand Down Expand Up @@ -576,13 +581,7 @@ function getVisibleElements({
last = visible.at(-1);

if (sortByVisibility) {
visible.sort(function (a, b) {
const pc = a.percent - b.percent;
if (Math.abs(pc) > 0.001) {
return -pc;
}
return a.id - b.id; // ensure stability
});
visible.sort(visibleSort);
}
return { first, last, views: visible, ids };
}
Expand Down