Tolerate unknown SEI and expose SEI payloads on decoded pictures - #94
Merged
Conversation
Signed-off-by: KP Choi <kp5.choi@samsung.com>
Signed-off-by: KP Choi <kp5.choi@samsung.com>
Signed-off-by: KP Choi <kp5.choi@samsung.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two decoder fixes plus the counterpart of the xeve SEI injection API:
(
default: xevd_assert_rv(0, XEVD_ERR_UNEXPECTED)), so any stream with astandard SEI such as mastering display colour volume was rejected. They are
now parsed past, as the spec requires.
loops until the trailing byte.
signature) are exposed on the output picture: when
imgb->ndata[XEVD_IMGB_SEI_SLOT] == XEVD_SEI_MAGIC,imgb->pdata[XEVD_IMGB_SEI_SLOT]points to anXEVD_SEIowned by thelibrary, valid until the imgb is released. The spare ndata/pdata fields are
used, so the ABI is unchanged. Slot 3 of the input bitstream buffer is no
longer propagated to output pictures (it is reserved for this).
The README gains a programming guide for the library including SEI reading,
plus small fixes.
Verified with a round trip against mpeg5/xeve#169: per-frame T.35 + MDCV
payloads with bframes=15 arrive frame-accurate in display order; decode
output of normal streams is unchanged; MAIN/BASE and x86/aarch64 builds pass;
AddressSanitizer run over the whole decode path is clean (including picture
buffer recycling).