Add per-picture SEI payload injection API - #169
Merged
Merged
Conversation
Signed-off-by: KP Choi <kp5.choi@samsung.com>
Signed-off-by: KP Choi <kp5.choi@samsung.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a public API to attach SEI payloads (HDR10 mastering display / content
light level, HDR10+ and other ITU-T T.35 messages, etc.) to individual
pictures, so callers like the FFmpeg wrapper can pass HDR metadata through.
Usage: fill an
XEVE_SEIlist and setimgb->pdata[XEVE_IMGB_SEI_SLOT]/imgb->ndata[XEVE_IMGB_SEI_SLOT] = XEVE_SEI_MAGICbeforexeve_push(). Thepayloads are deep-copied during the push, carried through frame reordering,
and written as prefix SEI NAL units (one per payload) into the access unit of
that picture. Payload bytes are passed through as-is; the library only does
the sei_message framing. The existing spare
ndata/pdatafields are used, sothe ABI is unchanged; the internal SEI type/struct definitions move to the
public header.
Also includes a README pass: SEI usage in the programming guide, typo fixes
(libxexe -> libxeve), fps option now documented as accepting fractions, and a
note that ARM hosts no longer need the cross-compile flags.
Verified with an encode/decode round trip against the xevd counterpart
(mpeg5/xevd#94): 16 frames with per-frame T.35 + MDCV payloads and bframes=15
come back frame-accurate on the decoder side; streams without SEI are
bit-exact with master; MAIN/BASE and x86/aarch64 builds pass; decoder-side
AddressSanitizer run is clean.