Skip to content

Hide the bottom navigation bar when a text file preview is shown - #17504

Open
daniele-verducci wants to merge 2 commits into
masterfrom
fix/17495
Open

Hide the bottom navigation bar when a text file preview is shown#17504
daniele-verducci wants to merge 2 commits into
masterfrom
fix/17495

Conversation

@daniele-verducci

@daniele-verducci daniele-verducci commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Fix #17495

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Changes

This hides the bottom navigation bar that was covering part of a previewed text file.

How to reproduce:

  • download a text file
  • open it
  • note the bottom bar over the text (on master)

…s shown

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci daniele-verducci self-assigned this Aug 19, 2026
binding.fabMain.setImageResource(R.drawable.ic_plus)
resetScrolling(true)
showSortListGroup(false)
showBottomNavigationBar(true)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobiasKaminsky should I check what's the popped fragment here? I didn't because, as far as I can see, the default status is for the bottom navigation to be visible. This is similar to what happens to resetScrolling().

@github-actions

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/32240739106/artifacts/9360935236
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/32345524977/artifacts/9398145437
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3232
Correctness5959
Dodgy code207207
Experimental11
Malicious code vulnerability22
Multithreaded correctness2525
Performance3939
Security1919
Total384384

@github-actions

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@daniele-verducci
daniele-verducci marked this pull request as ready for review August 20, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bottom menu covers file content

1 participant