Skip to content

Hide the bottom navigation bar when a text file preview is shown #17504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daniele-verducci wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Hide the bottom navigation bar when a text file preview is shown #17504

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba5ac3b
fix/17495: hides the bottom navigation bar when a text file preview i…
daniele-verducci Aug 19, 2026
b0d9871
Merge branch 'master' into fix/17495
daniele-verducci Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1358,6 +1358,7 @@ class FileDisplayActivity :
binding.fabMain.setImageResource(R.drawable.ic_plus)
resetScrolling(true)
showSortListGroup(false)
showBottomNavigationBar(true)

@daniele-verducci daniele-verducci Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobiasKaminsky should I check what's the popped fragment here? I didn't because, as far as I can see, the default status is for the bottom navigation to be visible. This is similar to what happens to resetScrolling().

supportFragmentManager.popBackStack()
}

Expand Down Expand Up @@ -2768,6 +2769,7 @@ class FileDisplayActivity :
val fragment = PreviewTextFileFragment.create(user, file, searchOpen, searchQuery)
setLeftFragment(fragment, false)
configureToolbarForPreview(file)
showBottomNavigationBar(false)
} else {
val previewIntent = Intent()
previewIntent.putExtra(EXTRA_FILE, file)
Expand Down
Loading