fix(tags): display selected tag in settings - #63508
Open
joshtrichards wants to merge 2 commits into
Open
Conversation
Fixes #63503 Signed-off-by: Josh <josh.t.richards@gmail.com>
The "Search for a tag to edit" field should show the selected tag as the selected option. It fails to do so because the object is passed instead of just the id. Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
kristian-zendato,
skjnldsv and
sorbaugh
and removed request for
a team
August 23, 2026 14:55
joshtrichards
added
bug
3. to review
joshtrichards
changed the base branch from
jtr/fix-tags-settings-limit
to
master
August 23, 2026 14:55
Member
Author
|
/backport to stable34 |
susnux
reviewed
Aug 23, 2026
| :placeholder="t('systemtags', 'Collaborative tags …')" | ||
| :fetchTags="false" | ||
| :options="tags" | ||
| :limit="null" |
Contributor
There was a problem hiding this comment.
That will cause type issues - either now or in the future at least.
Because limit is typed as number not number|null.
So either pass a real limit as number or do not pass limit meaning taking the default.
Otherwise if you need "all tags" then this needs a fix in the library allowing to pass null or 0
Member
Author
There was a problem hiding this comment.
Hmm. Implementation docs says otherwise - and I'm fairly certain I found this usage somewhere else already in production:
But I guess maybe you're right:
susnux
approved these changes
Aug 24, 2026
susnux
left a comment
susnux
left a comment
Contributor
There was a problem hiding this comment.
logic is fine - component documentation just wrong
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #Summary
The "Search for a tag to edit" field should display the selected tag, but it continues to show the placeholder after a tag is selected. It fails to do so because the object is passed instead of just the ID.
NcSelectTagsuses ID-based model values by default (passthruis false).onSelectTag()expects the numeric ID and resolves it againstprops.tags.This change passes the selected tag's ID instead, or
nullwhen no tag is selected:NcSelectTagsmatches the component's expected model format; andonSelectTag()handler remain consistent.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)