Skip to content

fix(tags): display selected tag in settings #63508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshtrichards wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −1
Open

fix(tags): display selected tag in settings #63508

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6bb53d
fix(tags): show more than five tags in settings
joshtrichards Aug 23, 2026
d521f7c
fix(tags): resolve selected tag in settings
joshtrichards Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/systemtags/src/components/SystemTagForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,11 +230,12 @@ function getTagLevel(userVisible: boolean, userAssignable: boolean): TagLevel {
<div class="system-tag-form__group">
<label for="system-tags-input">{{ t('systemtags', 'Search for a tag to edit') }}</label>
<NcSelectTags
:modelValue="selectedTag"
:modelValue="selectedTag?.id ?? null"
inputId="system-tags-input"
:placeholder="t('systemtags', 'Collaborative tags …')"
:fetchTags="false"
:options="tags"
:limit="null"

@susnux susnux Aug 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will cause type issues - either now or in the future at least.
Because limit is typed as number not number|null.
So either pass a real limit as number or do not pass limit meaning taking the default.

Otherwise if you need "all tags" then this needs a fix in the library allowing to pass null or 0

@joshtrichards joshtrichards Aug 24, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Implementation docs says otherwise - and I'm fairly certain I found this usage somewhere else already in production:

https://github.com/nextcloud-libraries/nextcloud-vue/blob/0e0af102a3d5aed8a1309bf17d2dc106959473c4/src/components/NcSelectTags/NcSelectTags.vue#L52

https://github.com/nextcloud/approval/blob/0f6ba8b8dd26a02f7f38d740ccfd24f8f2bbe2fa/src/components/ApprovalRule.vue#L42

But I guess maybe you're right:

https://github.com/nextcloud-libraries/nextcloud-vue/blob/0e0af102a3d5aed8a1309bf17d2dc106959473c4/src/components/NcSelectTags/NcSelectTags.vue#L195

:multiple="false"
labelOutside
@update:modelValue="onSelectTag">
Expand Down
Loading