Stop parsing interpro.xml once have release info - #85
Merged
Conversation
After adding additional logging I found `funannotate2 install -d interpro` was hanging in the XML parsing despite having already found the key information. This patch stops parsing the XML once the release information is found. The command then completes almost immediately after the download and unzip have finished.
Owner
|
If you find additional logging helpful, welcome the additions! Thanks for the help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After adding additional logging I found
funannotate2 install -d interprowas hanging in the XML parsing despite having already found the key information.This patch stops parsing the XML once the release information is found.
The command then completes almost immediately after the download and unzip have finished.
(Would additional logging for the typical three DB install steps of download, unzip, and parsing be welcome?)