Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes two fixes that improve the user experience and ensure consistent behavior across systems:
!importantFix 1: Custom Themes Work Without !important
Problem
Custom themes were being overridden by LSD's default theme variables, requiring users to add
!importantto every CSS variable - which violates CSS best practices.Solution
Reorganized theme variable definitions in
core.css:Before:
After:
Key Benefit
Users can define custom themes anywhere in their CSS (before OR after importing LSD) and it works the same:
Both work identically! When
data-themeis set, LSD's default selectors don't match, so custom themes win through natural CSS cascade.Usage
Fix 2: Calendar Date Format Standardization
Problem
The calendar component was using
toLocaleDateString()without specifying a locale, which made thedata-dayattribute format system-dependent:This caused test failures and inconsistent behavior across different environments.
Solution
Changed to ISO 8601 format (YYYY-MM-DD), which is:
Packages/lsd/src/components/ui/calendar/CalendarDayButton.tsx:
Packages/lsd/src/components/ui/calendar/tests/calendar.test.tsx: