Skip to content

fix(styles): custom themes work without !important; fix(calendar): standardize date format #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nipsysdev merged 2 commits into from
Apr 27, 2026
Merged

fix(styles): custom themes work without !important; fix(calendar): standardize date format #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2363953
fix(styles): reorganize theme variable definitions
nipsysdev Apr 27, 2026
b83862c
fix(calendar): standardize date attribute format to ISO 8601
nipsysdev Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/lsd/src/components/ui/calendar/CalendarDayButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ function CalendarDayButton({ className, day, modifiers, ...props }: CalendarDayB
ref={ref}
variant="ghost"
size="square-md"
data-day={day.date.toLocaleDateString()}
data-day={day.date.toISOString().split('T')[0]}
{...(isSelected && { 'data-selected-single': true })}
{...(isRangeStart && { 'data-range-start': true })}
{...(isRangeEnd && { 'data-range-end': true })}
Expand Down
2 changes: 1 addition & 1 deletion packages/lsd/src/components/ui/calendar/__tests__/calendar.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ describe('Calendar', () => {
const modifiers = {};
render(<CalendarDayButton day={day} modifiers={modifiers} />);
const button = screen.getByRole('button');
expect(button).toHaveAttribute('data-day', '1/15/2025');
expect(button).toHaveAttribute('data-day', '2025-01-15');
});

it('applies range start data attribute', () => {
Expand Down
82 changes: 25 additions & 57 deletions packages/lsd/src/styles/core.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,7 @@
--color-lsd-chart-5: #a855f7;
}

:root,
.light {
:root {
--radius: 0.625rem;

/* LSD spacing scale */
Expand All @@ -78,26 +77,7 @@
--lsd-spacing-larger: 1.5rem;
--lsd-spacing-largest: 1.75rem;

/* LSD Design Tokens - Light Theme */
--lsd-font-family: monospace;
--lsd-primary: #000000;
--lsd-primary-foreground: #ffffff;
--lsd-text-primary: #000000;
--lsd-text-secondary: #4a4a4a;
--lsd-border: #000000;
--lsd-icon-primary: #000000;
--lsd-icon-secondary: #ffffff;
--lsd-surface: #ffffff;
--lsd-destructive: #da0000;
--lsd-destructive-text: #c92d2d;
--lsd-success: #15803d;
--lsd-success-text: #1c9618;
--lsd-warning: #b45309;
--lsd-warning-text: #854d0e;
--lsd-info: #2563eb;
--lsd-info-text: #2563eb;

/* Shadcn variables using LSD values */
/* Shadcn variables using LSD values (always defined on :root) */
--background: var(--lsd-surface);
--foreground: var(--lsd-text-primary);
--card: var(--lsd-surface);
Expand Down Expand Up @@ -131,8 +111,29 @@
--sidebar-ring: var(--lsd-text-primary);
}

.dark {
/* LSD Design Tokens - Dark Theme */
:root:not([data-theme]):not([data-theme*=""]) {
/* LSD Design Tokens - Light Theme (defaults only) */
--lsd-font-family: monospace;
--lsd-primary: #000000;
--lsd-primary-foreground: #ffffff;
--lsd-text-primary: #000000;
--lsd-text-secondary: #4a4a4a;
--lsd-border: #000000;
--lsd-icon-primary: #000000;
--lsd-icon-secondary: #ffffff;
--lsd-surface: #ffffff;
--lsd-destructive: #da0000;
--lsd-destructive-text: #c92d2d;
--lsd-success: #15803d;
--lsd-success-text: #1c9618;
--lsd-warning: #b45309;
--lsd-warning-text: #854d0e;
--lsd-info: #2563eb;
--lsd-info-text: #2563eb;
}

.dark:not([data-theme]):not([data-theme*=""]) {
/* LSD Design Tokens - Dark Theme (defaults only) */
--lsd-font-family: monospace;
--lsd-primary: #ffffff;
--lsd-primary-foreground: #000000;
Expand All @@ -150,39 +151,6 @@
--lsd-warning-text: #f59e0b;
--lsd-info: #2563eb;
--lsd-info-text: #2563eb;

/* Shadcn variables using LSD values */
--background: var(--lsd-surface);
--foreground: var(--lsd-text-primary);
--card: var(--lsd-surface);
--card-foreground: var(--lsd-text-primary);
--popover: var(--lsd-surface);
--popover-foreground: var(--lsd-text-primary);
--primary: var(--lsd-primary);
--primary-foreground: var(--lsd-primary-foreground);
--secondary: var(--lsd-surface);
--secondary-foreground: var(--lsd-text-secondary);
--muted: var(--lsd-surface);
--muted-foreground: var(--lsd-text-secondary);
--accent: var(--lsd-surface);
--accent-foreground: var(--lsd-text-secondary);
--destructive: var(--color-lsd-destructive);
--border: var(--lsd-border);
--input: var(--lsd-surface);
--ring: var(--lsd-text-primary);
--chart-1: var(--color-lsd-chart-1);
--chart-2: var(--color-lsd-chart-2);
--chart-3: var(--color-lsd-chart-3);
--chart-4: var(--color-lsd-chart-4);
--chart-5: var(--color-lsd-chart-5);
--sidebar: var(--lsd-surface);
--sidebar-foreground: var(--lsd-text-primary);
--sidebar-primary: var(--lsd-primary);
--sidebar-primary-foreground: var(--lsd-primary-foreground);
--sidebar-accent: var(--lsd-surface);
--sidebar-accent-foreground: var(--lsd-text-primary);
--sidebar-border: var(--lsd-border);
--sidebar-ring: var(--lsd-text-primary);
}

@layer base {
Expand Down
Loading