Skip to content

feat(phone-connect): option to hide battery icon - #248

Closed
oldirtty wants to merge 1 commit into
noctalia-dev:mainfrom
oldirtty:feat/hide-bat-icon
Closed

feat(phone-connect): option to hide battery icon#248
oldirtty wants to merge 1 commit into
noctalia-dev:mainfrom
oldirtty:feat/hide-bat-icon

Conversation

@oldirtty

@oldirtty oldirtty commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Plugin

  • Id: icefish/phone-connect
  • New plugin
  • Update to an existing plugin (version bumped in plugin.toml)

What it does

Add widget option to hide battery icon.

External dependencies

None

Testing

  • Tested on Niri
  • Tested on Hyprland
  • Tested on Sway
  • Tested on another compositor:
  • Noctalia version tested against: v5.0.0-beta.7-71-ge41c99439605)
  • Plugin API level: 16

Screenshots / Videos

None

Checklist

  • The directory name matches the part of id after the / in plugin.toml exactly.
  • It ships plugin.toml, README.md, thumbnail.webp, and translations/en.json.
  • README.md follows the
    README template, documents
    every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
  • I created thumbnail.webp with the thumbnail generator.
  • version follows semver and is bumped in this PR; plugin_api is the oldest API level this plugin requires.
  • Every non-English translation in this PR uses a locale supported by Noctalia core, and I can read, write, and
    understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
  • I did not edit catalog.toml; CI generates it.
  • This PR touches exactly one plugin directory.

Code review attestation

Plugins run as trusted, unsandboxed Luau in the user's session. Confirm:

  • The code is readable and not obfuscated, minified, or generated.
  • It does not download and execute remote code.
  • Every network call, filesystem write, and spawned process is something the description above accounts for.
  • I have the right to publish this code under the license declared in plugin.toml.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

CC @CSY2569

@ItsLemmy
ItsLemmy marked this pull request as draft August 5, 2026 21:40
@spiros132
spiros132 force-pushed the main branch 5 times, most recently from 8d53319 to d59cdac Compare August 7, 2026 22:57
@CSY2569

CSY2569 commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Thanks! #344 covers this with a fuller battery_display option (icon_and_percent / percent / icon / hidden), which includes "hidden". I would suggest closing this in favor of #344 to avoid two PRs editing the same widget battery code and bumping the version independently.

@oldirtty

Copy link
Copy Markdown
Contributor Author

Cool, #344 is way better indeed! I'll be closing this PR then.

@oldirtty oldirtty closed this Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants