feat(phone-connect): allow configuring bar widget contents - #344
Conversation
|
CC @CSY2569 |
|
out of curiosity, why was this marked as a draft? is it something that i need to change? are we just waiting for approval from @CSY2569 or will they need to make changes afterwards as well? |
|
Thanks for the PR, and sorry for the slow reply — the bot CCs me as the plugin author, but I do not have merge rights in this repo, so a maintainer will still need to review and merge. This looks good and is a clean superset of #248 (hide battery icon), so I would suggest closing #248 in favor of this one. One gap: this only updates Re: your draft question — the draft status is set on the PR itself, not something I control. Once it is marked ready for review, a maintainer can pick it up. From my side as the plugin author, this looks good to merge (modulo the translation gap above). |
|
Yeah, I was only allowed to update the English translations, as that's the only language I'm capable of actually verifying. As for approval, I'm pretty sure the maintainer should merge it once you've given the OK, but repo rules say that your plugins won't be modified without original owner's approval, other than with bug fixes or tree-wide changes. I don't think you can modify this PR to add the translations on top, but I think a subsequent PR would work fine! Thanks 👍 |
Plugin
icefish/phone-connectplugin.toml)What it does
Now available in user configuration:
External dependencies
None
Testing
Screenshots / Videos
Checklist
idafter the/inplugin.tomlexactly.plugin.toml,README.md,thumbnail.webp, andtranslations/en.json.README.mdfollows theREADME template, documents
every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
thumbnail.webpwith the thumbnail generator.versionfollows semver and is bumped in this PR;plugin_apiis the oldest API level this plugin requires.understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
catalog.toml; CI generates it.Code review attestation
Plugins run as trusted, unsandboxed Luau in the user's session. Confirm:
licensedeclared inplugin.toml.