Skip to content

feat(phone-connect): allow configuring bar widget contents - #344

Draft
redxtech wants to merge 1 commit into
noctalia-dev:mainfrom
redxtech:add-phone-connect-options
Draft

feat(phone-connect): allow configuring bar widget contents#344
redxtech wants to merge 1 commit into
noctalia-dev:mainfrom
redxtech:add-phone-connect-options

Conversation

@redxtech

Copy link
Copy Markdown
Contributor

Plugin

  • Id: icefish/phone-connect
  • New plugin
  • Update to an existing plugin (version bumped in plugin.toml)

What it does

Now available in user configuration:

  • enable/disable phone name in bar widget
  • choose whether bar widget show battery icon, percent, both, or neither.

External dependencies

None

Testing

  • Tested on Niri
  • Tested on Hyprland
  • Tested on Sway
  • Tested on another compositor:
  • Noctalia version tested against: recent main (nixos)
  • Plugin API level: 16

Screenshots / Videos

image image image

Checklist

  • The directory name matches the part of id after the / in plugin.toml exactly.
  • It ships plugin.toml, README.md, thumbnail.webp, and translations/en.json.
  • README.md follows the
    README template, documents
    every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
  • I created thumbnail.webp with the thumbnail generator.
  • version follows semver and is bumped in this PR; plugin_api is the oldest API level this plugin requires.
  • Every non-English translation in this PR uses a locale supported by Noctalia core, and I can read, write, and
    understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
  • I did not edit catalog.toml; CI generates it.
  • This PR touches exactly one plugin directory.

Code review attestation

Plugins run as trusted, unsandboxed Luau in the user's session. Confirm:

  • The code is readable and not obfuscated, minified, or generated.
  • It does not download and execute remote code.
  • Every network call, filesystem write, and spawned process is something the description above accounts for.
  • I have the right to publish this code under the license declared in plugin.toml.

@github-actions

Copy link
Copy Markdown
Contributor

CC @CSY2569

@ItsLemmy
ItsLemmy marked this pull request as draft August 12, 2026 13:21
@redxtech

Copy link
Copy Markdown
Contributor Author

out of curiosity, why was this marked as a draft?

is it something that i need to change? are we just waiting for approval from @CSY2569 or will they need to make changes afterwards as well?

@CSY2569

CSY2569 commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Thanks for the PR, and sorry for the slow reply — the bot CCs me as the plugin author, but I do not have merge rights in this repo, so a maintainer will still need to review and merge.

This looks good and is a clean superset of #248 (hide battery icon), so I would suggest closing #248 in favor of this one.

One gap: this only updates translations/en.json. The plugin also ships Simplified Chinese (translations/zh-Hans.json), so the two new settings (show_device_name, battery_display + its option labels) will render raw keys for Chinese users. I will add the zh-Hans entries myself as a follow-up, so no action needed from you on that.

Re: your draft question — the draft status is set on the PR itself, not something I control. Once it is marked ready for review, a maintainer can pick it up. From my side as the plugin author, this looks good to merge (modulo the translation gap above).

@redxtech

Copy link
Copy Markdown
Contributor Author

Yeah, I was only allowed to update the English translations, as that's the only language I'm capable of actually verifying.

As for approval, I'm pretty sure the maintainer should merge it once you've given the OK, but repo rules say that your plugins won't be modified without original owner's approval, other than with bug fixes or tree-wide changes.

I don't think you can modify this PR to add the translations on top, but I think a subsequent PR would work fine!

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants