Repository navigation
frontend: clean up comments, docs, dead code and tests - #236
Merged
Merged
Conversation
zimbatm
enabled auto-merge
October 23, 2026 23:54
Three display tests carried a doc comment that only repeated the test name. Assisted-by: Claude Code (claude-opus-5) Change-Id: I680e3c413d9f1240bea78d691ad156a15d6128a9
Move the doc of the --iets-option value parser from read_builders, where it sat by mistake, to flag_value. Join doc lines that broke in the middle of a sentence. Drop "simply" and first-person wording. Assisted-by: Claude Code (claude-opus-5) Change-Id: I15ed8369f2e7dc0266f6104ad3e2ef4879e51ecf
cli::search::drv_name and the body of api::installable::drv_pname were two more copies of names.cc:DrvName. Both now call builtins::strings::parse_drv_name_bytes, the one parseDrvName uses. The split rule is the same in all three: a dash followed by a byte that is not an ASCII letter. The drv_names and the_name_a_program_takes_from_a_derivation_name tests still pass unchanged against the shared helper. Assisted-by: Claude Code (claude-opus-5) Change-Id: I02622f88db6f68edaa16d8b95c54f8bdb60192b4
print::tests::float_formatting_is_never_empty only checked that format_g and json_float return a non-empty string. Six of its eleven values were already in float_formatting_edge_cases, which checks the exact text. The other five (0.0, -1e300, f64::MIN_POSITIVE, 1.0, 0.1) are now cases of float_formatting_edge_cases with their exact text, so the merged table checks more than the two tests did. Assisted-by: Claude Code (claude-opus-5) Change-Id: I4d3df87555a086471c7bc24ffb88ddbd01947ee9
zimbatm
force-pushed
the
cleanup/frontend
branch
from
October 24, 2026 01:37
f5a2db9 to
85592c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup of src/cli, src/api, src/jobs, src/flake, src/lint, src/devenv and the top-level src/*.rs files.
--iets-option VALUEtext moved fromread_builderstoflag_value, which it describes.src/cli/search.rshad a private copy of thebuiltins.parseDrvNamesplit, andsrc/api/installable.rshad another. Both now callbuiltins::strings::parse_drv_name_bytes. The rule is the same in all three copies.float_formatting_is_never_emptymerged intofloat_formatting_edge_cases. Its 11 values are now exact-value cases, so the test checks more than before.No user-visible text changed. A second review found nothing to restore. fmt, clippy, ast-grep and the full test suite pass, also merged with the other three cleanup branches.