Repository navigation
core: clean up comments, docs, dead code and tests - #237
Merged
Merged
Conversation
zimbatm
enabled auto-merge
October 23, 2026 23:54
Remove the `// parallel` tags after `parallel::fanout_*` calls: the call names the module. Remove four comments that repeat the line or the signature below them. Assisted-by: Claude Code (claude-opus-5) Change-Id: I01ca1b7d182bfab4aef1287664d8b89fda9b1220
Split long doc sentences, use the active voice and turn two run-on lists into bullet lists: the thunk layout, the map descriptor, the IR cache, the IR, the arena, the word bits, store_hooks, fetchTree, the path primops, the watch selection, the derivation position and EvalConfig::is_pure. Every fact, limit and pointer stays. Assisted-by: Claude Code (claude-opus-5) Change-Id: I92c1b76091f39e801d124d952c54b3f0aec568cc
Drop eleven `runtime` re-exports that nothing uses: AttrIter, FloatObj, IntObj, LambdaObj, MapDesc, PathObj, PrimOpAppObj, PrimOpObj, ThunkApp2Obj, ThunkAppObj and UnionTail. With the module made crate-private, the compiler reports them as unused imports, and no file under src/, tests/, fuzz/, bench/, examples/ or docs/ names them through `runtime::`. The types stay in `runtime::value`. Assisted-by: Claude Code (claude-opus-5) Change-Id: I32714288e1f107df460b9e7dcbfb5510584ffd61
No test is removed. The eval tests had three copies of the evaluate-force-print body (eval_str, eval_pure and the closure in nix_eq_forces_what_the_shortcut_skips); they now share eval_with. The syntax tests had four copies of the "parse must fail" block; they now share parse_error, which parse_err also uses. Assisted-by: Claude Code (claude-opus-5) Change-Id: I40c678d2cac117ddcf83c5fc15b57d1bc0067d6d
- runtime/arena.rs: say again that graph sharing between cells is sound Assisted-by: Claude Code (claude-opus-5) Change-Id: If56bbdcbf8bfd772d1d8a8b92cfc0e2768c861b9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup of src/eval, src/runtime, src/compile, src/syntax, src/parallel, src/trace, src/corepkgs and src/builtins.
// paralleltags afterfanout_*calls. Comments that name the mechanism stay.pub usere-exports insrc/runtime/mod.rsthat nothing uses. The types stay atiets::runtime::value::*. An outside library user of the old paths must change the import; docs/reference/library.md says the API can change.eval/tests.rsandsyntax/tests.rsshare one helper each for evaluate-and-print and for parse-must-fail.src/runtime/arena.rsmodule doc.src/corepkgs/*.nix is unchanged, because it is a copy of upstream Nix. fmt, clippy, ast-grep and the full test suite pass.