[16.0][FIX] ptplus_partner: guard 16.0 column renames with column_exists - #3
Open
eantones wants to merge 1 commit into
Open
[16.0][FIX] ptplus_partner: guard 16.0 column renames with column_exists#3eantones wants to merge 1 commit into
eantones wants to merge 1 commit into
Conversation
The 16.0.4.0.1 and 16.0.4.0.2 pre-migrations rename res_bank/res_partner columns behind a registry-membership check only. On databases where the target column already exists (e.g. a healed or partially-migrated DB), rename_fields dies with DuplicateColumn and kills the whole upgrade. Add a column_exists guard so the rename only runs when the target column is still absent. Pristine vendor installs keep the vendor behavior; DBs that already carry the column skip the rename instead of crashing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 16.0.4.0.1 and 16.0.4.0.2 pre-migrations rename
res_bank/res_partnercolumns behind a registry-membership check only. On databases where the target column already exists (healed or partially-migrated DBs),rename_fieldsdies withDuplicateColumnand kills the whole upgrade.Add a
column_existsguard so the rename only runs when the target column is still absent. Pristine vendor installs keep the vendor behavior; DBs that already carry the column skip the rename instead of crashing.Replaces the aggregate-time seds previously carried in our deployment config — policy: every code change is a published PR, never an aggregate-time mutation. To be reported to the vendor (Exo) as well.
Note: the vendor mirror is bot-published with force-pushed orphan snapshots per release — when exo 16.0 head moves, rebase this branch onto the new snapshot (rebase operativa).