fix(#1172): EO 0.62.1 - #1205
Conversation
|
/benchmark |
Benchmark comparison for #1205Comparing this branch against the Biggest changes
Full results (420 entries)
|
|
@volodya-lombrozo take a look, please |
volodya-lombrozo
left a comment
There was a problem hiding this comment.
@h1alexbel There are too many changes. Is there any possibility to bump eo-parser version without changing so many files at once? Maybe we can somehow ignore some problems by leaving issues (aka puzzles)?
|
@volodya-lombrozo take a look, please
@volodya-lombrozo this is indeed a huge PR. However, it is for reason to fix all parsing errors, mainly with empty lines after comments and before test attributes. I did all the job here, in this PR because didn't want to leave the code in partial state, with many |
|
/benchmark |
|
@volodya-lombrozo looks like CI blocked :( |
|
@rultor merge |
@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here. |
@h1alexbel @volodya-lombrozo Oops, I failed. You can see the full log here (spent 5min). |
|
@h1alexbel could you resolve all the conversations, please? |
|
@volodya-lombrozo resolved |
|
@volodya-lombrozo Thanks for the review! You've earned +24 points for this: +12 as a basis; +7 for the 722 hits-of-code that you reviewed; +6 for the 25 comment(s) that you have made; -1 to not go over the cap. Your running score is +616; don't forget to check your Zerocracy account too). |
|
@rultor merge |
@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here. |
@volodya-lombrozo Done! FYI, the full log is here (took me 5min). |
|
@h1alexbel Thanks for the contribution! You've earned +4 points for this: +16 as a basis; -4 for too many hits-of-code (722 >= 100); -8 for way too many hits-of-code (722 >= 400); -4 for too many (40 > 4) comments that were made during review; +4 to give you at least something. Please, keep them coming. Your running score is +77; don't forget to check your Zerocracy account too). |
In this PR I've updated EO to the latest version:
0.62.1.closes #1172