Skip to content

test(console,app-shell,scripts): three 1-site specifiers join COVERED_SPECIFIERS (objectui#6892 slice 1) - #8020

Merged
baozhoutao merged 1 commit into
mainfrom
claude/issue-6892-vi-mock-inherit-slice1
Sep 6, 2026
Merged

test(console,app-shell,scripts): three 1-site specifiers join COVERED_SPECIFIERS (objectui#6892 slice 1)#8020
baozhoutao merged 1 commit into
mainfrom
claude/issue-6892-vi-mock-inherit-slice1

Conversation

@claude

@claude claude Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Part of #6892

The first slice of the vi.mock inheritance worklist: the three specifiers the card's triage named as the flow-proving start, because each carried exactly one frozen factory. Each factory now obtains the real module and spreads it before its own overrides, and the three specifiers join COVERED_SPECIFIERS in the same PR — the widening precondition the gate's own header states, and the one #6849's ruling forbids splitting.

Verified at de7470dc8.

Re-derived per-specifier table — ⛔ not the card's

The card's table (9ce20233f) is stale twice over: it predates the recogniser repair in #7889 (the old classifier over-reported frozen) and the @object-ui/i18n flip in #7920. Both are on main. Everything below was measured on this branch with the fixed classifier.

The gate's CLI cannot produce this table on an unmodified tree — --list judges only the covered set and reports the rest as out of scope, and the script takes no flag or env override. But scan() is exported and accepts a covered option, so the table is derived without touching the tree at all: pass 1 collects every workspace specifier any vi.mock call site names, pass 2 judges them all.

import { scan } from './scripts/check-vi-mock-inherit.mjs';
const probe = scan(root, { covered: [] });
const specifiers = [...new Set(probe.sites.filter((s) => s.scope === 'workspace').map((s) => s.specifier))];
const all = scan(root, { covered: specifiers, floors: {} });   // tabulate all.sites by specifier

This slice's three, before and after:

specifier judged inherits before frozen before inherits after frozen after
@object-ui/plugin-markdown 1 0 1 1 0
@object-ui/data-objectstack 1 0 1 1 0
@object-ui/plugin-report 1 0 1 1 0

The whole population, over the 22 workspace specifiers any call site in the tree names:

before after
judged call sites 640 640
inheriting 322 325
frozen 318 315
unreadable / indirect 0 0

Zero sites moved the other wayinherits rises by exactly 3 as frozen falls by exactly 3, and the per-specifier rows for the other 19 specifiers are byte-identical between the two runs.

⚠️ Note for whoever scopes slice 2: 318, not 298, and 22 specifiers, not the card's 15 rows. The population is over every @object-ui/* specifier a vi.mock call site actually names — which includes the subpath @object-ui/components/ui/sonner — rather than over the package list. The remaining table is in this PR's report on #6892 so the next slice can be scoped from it without re-deriving; the largest is @object-ui/auth at 102 frozen (the card said 92), and @object-ui/app-shell at 23 still reads #6580 first.

The conversion, per file

All three take the spelling already used by their neighbours in the same file (docs-portal.test.tsx's own @object-ui/i18n factory is line-for-line this shape), with the spread inserted as the first property so each test's own stubs still shadow the real export exactly as before.

file specifier what the factory overrides
apps/console/src/pages/docs-portal.test.tsx:52 @object-ui/plugin-markdown MarkdownRenderer, extractToc
packages/app-shell/src/chrome/ConditionalAuthWrapper.previewRetired-6654.test.tsx:72 @object-ui/data-objectstack getSharedDiscovery
packages/app-shell/src/views/ReportView.dataSourceObjectKey.test.tsx:60 @object-ui/plugin-report ReportRenderer

None of the three is a deliberate freeze. Each was read for the "prove the module is NOT loaded" shape the gate's header carves out, and each is an ordinary stub-the-renderer / stub-the-helper factory that says so in its own comment where it says anything at all.

Behaviour preservation

Spreading the real module means each mock now returns exports it previously omitted, so this was checked rather than assumed, on PR #6847's criteria:

  1. Nothing can observe the mock's key set. import * as ns from any of the three specifiers returns no hits repo-wide, so there is no namespace object for an Object.keys or in test to read.
  2. No absence assertion is about the mocked module. Every toBeUndefined / toBeNull in the three files was read: they are about AuthProvider's props (facts.previewMode) and about query params, never about an export.
  3. Overrides still win — the spread is the first property in all three.
  4. All three resolve to src/, not dist/. The root vitest.config.mts aliases all three specifiers to their package src/, so importOriginal() reads source and no build stands between the edit and the run.

Reverse verification — two legs, three times

Committed first, then mutated: the restore leg points at HEAD, and HEAD carries the implementation. Each leg proves itself on disk — the mutation by counting the deleted spread marker and the injected frozen form, the restore by git hash-object equal to the HEAD blob and an empty git diff HEAD. Restore runs from a trap ... EXIT INT TERM with absolute paths built from git rev-parse --show-toplevel.

Leg A — re-freeze one factory, keep the flip. The gate goes RED, exit 1, naming that site and no other:

- apps/console/src/pages/docs-portal.test.tsx:52 -- vi.mock("@object-ui/plugin-markdown")
  the factory never obtains the real module
- packages/app-shell/src/chrome/ConditionalAuthWrapper.previewRetired-6654.test.tsx:72 -- vi.mock("@object-ui/data-objectstack")
  the factory never obtains the real module
- packages/app-shell/src/views/ReportView.dataSourceObjectKey.test.tsx:60 -- vi.mock("@object-ui/plugin-report")
  the factory never obtains the real module

(three separate runs, one per specifier — each red names exactly its own site)

Leg B — restore. Blobs 2cc7d34f1, 7e12f8d8f, 6995e8c75, each equal to HEAD's, git diff HEAD empty, gate exit 0 each time.

This is what makes the three new COVERED_SPECIFIERS lines load-bearing rather than decorative: without them Leg A would stay green, because an unlisted specifier is never judged.

The guard's own pin needed no edit

Expected to redden and did not, so it is recorded rather than assumed. Every membership assertion in scripts/__tests__/check-vi-mock-inherit.test.ts is derived from the constant rather than spelling it — COVERED_SPECIFIERS.length > 0, a loop resolving each member to a real packages/NAME/package.json, and const named = COVERED_SPECIFIERS.join(', ') for the verdict line. All three new members live under packages/, so all 69 cases pass unchanged.

That derivation has a flip side this PR inherits rather than creates, and it is filed separately as #8018, not addressed here: the only membership pin that resists removal names @object-ui/i18n alone, so dropping @object-ui/react (134 sites) or any of these three from the list leaves every gate green over a population nobody looks at.

Gates

All run at de7470dc8, exit codes captured by redirect-then-capture.

gate exit reading
pnpm check:vi-mock-inherit 0 229 call site(s) on @object-ui/react, @object-ui/i18n, @object-ui/plugin-markdown, @object-ui/data-objectstack, @object-ui/plugin-report judged (229 inherit, 0 auto-mocked)
vitest run scripts/__tests__/check-vi-mock-inherit.test.ts 0 Test Files 1 passed, Tests 69 passed
vitest run the three converted files 0 Test Files 3 passed (3), Tests 17 passed (17)
vitest run packages/app-shell/ 0 Test Files 632 passed (632), Tests 6077 passed | 1 skipped (6078)
vitest run apps/console/ 0 Test Files 89 passed (89), Tests 981 passed (981)
pnpm check:vi-mock-specifiers 0 OK (4354 tracked source file(s) ... 868 relative specifier(s) resolved)
pnpm type-check:scripts 0 clean tsc -p tsconfig.scripts.json
pnpm check:control-bytes 0 OK (scanned 6444 tracked text file(s); skipped 85 binary)
grep -naP control-byte self-scan of all 5 changed paths 1 no match — clean
node scripts/check-changeset-presence.mjs 0 3 source file(s) of 2 released package(s) changed ... Every one of them has an EMPTY frontmatter
node scripts/check-governed-queue-guard.mjs --test (all 5 paths) 0 NOT GOVERNED — 4 path(s) checked against 5 governed surface(s); none matched
per-package type-check (4 affected packages) 0 non-vacuous: --listFiles names each edited test file — app-shell's tsconfig.test.json program 4421 files, console's 3510
per-package lint (eslint ., full, not narrowed) 0 app-shell 1087 files, 0 errors; console 189 files, 0 errors; both name the edited files in --format json. The changed gate script and changeset lint clean too

The changeset declares an empty frontmatter: the three edited files are test files under released packages' src/, and nothing published changes.

Live E2E (informational) is red on every branch today for an upstream reason (#7990 / objectstack#16186) and is not this PR's.

Scope of "affected" was derived rather than guessed: TURBO_SCM_BASE=eeda78a780 turbo ls --affected names four packages — app-shell and console (whose test files changed) plus example-byo-backend-console and example-console-starter, which are pulled in by the dependency graph alone. The examples carry no test script, and a .test.tsx edit inside another package cannot reach them; their type-check is green here. Also green and unmentioned above because they are cheap siblings of the changeset gate: check-changeset-fixed, check-changeset-no-major, check-changeset-overwrite, check-lint-coverage (46/46 packages linted, 0 with outstanding errors).


Generated by Claude Code

…site specifiers

The three specifiers objectui#6892's triage named as the flow-proving start
carried exactly one frozen `vi.mock` factory each. Each factory now obtains the
real module and spreads it before its own overrides, and the three specifiers
join `COVERED_SPECIFIERS` in the same commit -- the widening precondition the
gate's own header states.

Re-derived with the FIXED classifier (objectui#7889) on a tree carrying the
`@object-ui/i18n` flip (objectui#7920), never from the worklist's stale table:
each of the three read 1 judged / 0 inheriting / 1 frozen before, 1 / 1 / 0
after, with the all-specifier population moving 318 -> 315 frozen and no site
moving the other way.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FhBNJcLRZLe8M87VcUgpKr
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 50 chunks) 3186.0 KB 3191.4 KB
Main entry chunk (gzip) 143.5 KB 350 KB
Entry file index-BO0uFEv5.js
Status PASS

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 15.67KB 5.75KB
app-shell (runtime-config.js) 20.68KB 7.36KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.06KB 3.86KB
auth (ActiveOrganizationStorage.js) 25.05KB 9.16KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.18KB 10.59KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.65KB 2.22KB
auth (SocialSignInButtons.js) 9.61KB 3.89KB
auth (UserMenu.js) 3.41KB 1.23KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.21KB 10.80KB
auth (createAuthenticatedFetch.js) 8.46KB 3.43KB
auth (index.js) 3.19KB 1.44KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 5.13KB 2.35KB
collaboration (CommentThread.js) 26.08KB 7.56KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 497.06KB 113.79KB
core (index.js) 6.96KB 2.79KB
create-plugin (index.js) 10.08KB 3.26KB
data-objectstack (index.js) 182.08KB 50.62KB
fields (index.js) 242.44KB 61.25KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 1.22KB 0.64KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 4.28KB 1.75KB
i18n (index.js) 3.65KB 1.47KB
i18n (pickLocalized.js) 7.62KB 3.26KB
i18n (provider.js) 26.89KB 9.04KB
i18n (useDisplayLocale.js) 2.85KB 1.45KB
i18n (useObjectLabel.js) 34.34KB 9.17KB
i18n (useSafeTranslation.js) 5.60KB 2.33KB
layout (index.js) 38.84KB 10.94KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 4.39KB 1.66KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 11.71KB 4.29KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.24KB 2.16KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 5.12KB 1.74KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 15.16KB 3.68KB
plugin-calendar (index.js) 47.35KB 13.21KB
plugin-charts (index.js) 70.31KB 19.62KB
plugin-chatbot (index.js) 193.53KB 46.05KB
plugin-dashboard (index.js) 131.41KB 34.43KB
plugin-designer (index.js) 211.51KB 43.01KB
plugin-detail (index.js) 247.59KB 63.48KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 131.01KB 32.32KB
plugin-gantt (index.js) 167.16KB 40.99KB
plugin-grid (index.js) 208.56KB 56.63KB
plugin-kanban (index.js) 52.30KB 14.49KB
plugin-list (index.js) 113.24KB 27.66KB
plugin-map (index.js) 20.35KB 6.77KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 43.42KB 11.92KB
plugin-timeline (index.js) 29.95KB 8.67KB
plugin-tree (index.js) 9.16KB 3.18KB
plugin-view (index.js) 84.33KB 20.75KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.66KB 3.50KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 81.07KB 26.86KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.63KB 2.18KB
react (schema-input.js) 2.32KB 1.24KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (codegen.js) 5.41KB 2.34KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 4.93KB 2.24KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 20.57KB 5.88KB
sdui-parser (provenance.js) 3.66KB 1.82KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 10.35KB 3.60KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 1.00KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 2.74KB 1.41KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 4.74KB 2.25KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 4.73KB 2.28KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 5.05KB 1.93KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

Copy link
Copy Markdown
Contributor

Standing-down note — Live E2E (informational) is red on main and on every branch today: the upstream base-red anchored on #7990 (objectstack#16186). It is continue-on-error by design, never blocks the queue, and touches nothing this diff changes (three vi.mock factories, three lines of COVERED_SPECIFIERS, one empty changeset). Not this PR's to fix; no re-run requested. ACCEPTed on the card (#6892); flip and arming follow once the remaining checks conclude.


Generated by Claude Code

@baozhoutao
baozhoutao marked this pull request as ready for review September 6, 2026 10:51
@baozhoutao
baozhoutao added this pull request to the merge queue Sep 6, 2026
Merged via the queue into main with commit 0eb0489 Sep 6, 2026
33 of 34 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-6892-vi-mock-inherit-slice1 branch September 6, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants