Skip to content

fix(stdune): relativize external paths on Windows - #16280

Closed
Alizter wants to merge 1 commit into
ocaml:cover-windows-path-rootsfrom
Alizter:fix-windows-path-reach
Closed

fix(stdune): relativize external paths on Windows#16280
Alizter wants to merge 1 commit into
ocaml:cover-windows-path-rootsfrom
Alizter:fix-windows-path-reach

Conversation

@Alizter

@Alizter Alizter commented Aug 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Relativize external Windows paths when the source and destination share a
current-drive root, drive letter, or UNC share, including the corresponding
extended path forms. Paths crossing drives, UNC shares, or root kinds remain
absolute.

This completes the Windows support left out of #15077.

Stack

  1. test(stdune): enable path tests on Windows #16278 (merged)
  2. test(stdune): cover external Windows path roots #16279
  3. This PR

@Alizter
Alizter force-pushed the fix-windows-path-reach branch from deee06c to 9448ddc Compare August 31, 2026 09:29
This was referenced Aug 31, 2026
Merged
Merged
Closed
@Alizter
Alizter force-pushed the cover-windows-path-roots branch from 3c32d94 to 7546a2f Compare August 31, 2026 10:30
@Alizter
Alizter force-pushed the fix-windows-path-reach branch from 9448ddc to f9e389c Compare August 31, 2026 10:30
Alizter added a commit that referenced this pull request Aug 31, 2026
@Alizter
test(stdune): enable path tests on Windows (#16278)
bdb212c 
## Description

Run the stdune path tests as part of `@runtest-windows`.

Keep the existing platform-specific `Path.External.reach` result in the
test so
this change only enables coverage; it does not change path behavior.

## Stack

1. This PR
2. #16279
3. #16280
@Alizter
Alizter force-pushed the cover-windows-path-roots branch from 7546a2f to 2142a08 Compare August 31, 2026 11:19
@Alizter
Alizter force-pushed the fix-windows-path-reach branch from f9e389c to 5a1396f Compare August 31, 2026 11:19
@Alizter
fix(stdune): relativize external Windows paths
8754855 
Signed-off-by: Ali Caglayan <alizter@gmail.com>
@Alizter
Alizter force-pushed the cover-windows-path-roots branch from 2142a08 to c8211d6 Compare August 31, 2026 11:43
@Alizter
Alizter force-pushed the fix-windows-path-reach branch from 5a1396f to 8754855 Compare August 31, 2026 11:43
Alizter added a commit that referenced this pull request Aug 31, 2026
@Alizter
test(stdune): cover external Windows path roots (#16279)
01fcdef 
## Description

Add Windows characterization tests for current-drive, drive-letter, UNC,
and
extended external paths. The same-root cases record that paths currently
remain
absolute, while the different-root cases protect that behavior.

## Stack

1. #16278 (merged)
2. This PR
3. #16280
@Alizter
Alizter deleted the branch ocaml:cover-windows-path-roots August 31, 2026 12:38
@Alizter Alizter closed this Aug 31, 2026
@Alizter Alizter mentioned this pull request Aug 31, 2026
Open
@Alizter

Alizter commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by #16285 after the characterization PR was merged and this branch was rebased onto main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Alizter