Conversation
Alizter
force-pushed
the
fix-windows-path-reach
branch
from
August 31, 2026 13:39
ccd2649 to
b276a81
Compare
Alizter
force-pushed
the
fix-windows-path-reach
branch
2 times, most recently
from
August 31, 2026 14:40
1dd99b2 to
7674fa5
Compare
Alizter
force-pushed
the
fix-windows-path-reach
branch
from
August 31, 2026 14:54
7674fa5 to
b023e63
Compare
Alizter
marked this pull request as ready for review
August 31, 2026 16:16
Keep other Windows namespaces and unsupported path forms absolute. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
fix-windows-path-reach
branch
from
August 31, 2026 16:18
b023e63 to
1befac5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Relativize ordinary drive-rooted Windows paths when the source and destination
are on the same drive.
Conservatively keep current-drive-rooted, drive-relative, UNC, extended-length,
device, malformed, ADS, and different-drive paths absolute. The characterization
tests in #16279 cover these boundaries.
This follows #16278 and #16279 and completes the ordinary drive-path portion of
the Windows support left out of #15077. It supersedes the automatically closed
#16280.