fix(action-plugin): resolve client paths from the current directory - #16384
Merged
Merged
Conversation
rgrinberg
force-pushed
the
push-tykyvsxnwklk
branch
from
September 12, 2026 20:40
ebf57f8 to
8613d1c
Compare
rgrinberg
force-pushed
the
push-tykyvsxnwklk
branch
2 times, most recently
from
September 12, 2026 20:55
6e04555 to
57cd123
Compare
Return the physical, sandbox-mapped build-context root in an initialization response record. Clients snapshot cwd before yielding, send root-relative dependency paths, and use the captured absolute paths for file and directory I/O. Keep the standalone context API unchanged. Resolve symlinks in the existing action root, without requiring generated inputs to exist before discovery. Document the path semantics and flip the preceding regressions for reads, listings, dependency invalidation, in-flight cwd changes, and sandboxed or symlinked build directories. Leave RPC socket discovery and the helper-starts-in-another-directory regression unchanged. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-tykyvsxnwklk
branch
from
September 12, 2026 21:08
57cd123 to
e5bd5f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve action-plugin dependency paths from the client’s current directory rather than its launch directory. Capture paths before waiting for Dune so a concurrent directory change cannot redirect file or directory reads.
Return the physical, sandbox-mapped build-context root in an initialization response record and translate requests into that root-relative namespace.
Related to #5681.