Conversation
Advertise an absolute RPC endpoint so subprocesses started in another working directory can connect using the inherited DUNE_RPC environment. Relativize Unix socket addresses at client discovery time to preserve short socket paths, and document the requirement to connect before changing directories again. Flip the existing helper regression from failure to success. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-nttlvsztyvso
branch
from
September 12, 2026 21:33
c089768 to
f33b577
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dynamic action can launch a subprocess in another working directory. That subprocess inherits DUNE_RPC, but an address relative to the parent’s launch directory no longer locates the server.
Advertise an absolute RPC endpoint, then shorten Unix socket addresses relative to each client’s cwd at discovery time to preserve the socket path-length budget. Document that clients must connect before changing directories again, and flip the existing helper regression from failure to success.
Follow-up to #16384. Related to #5681.